Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly wider tolerance to arithmetic mismatches with Pandas with floats #2244

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

poodlewars
Copy link
Collaborator

https://github.com/man-group/ArcticDB/actions/runs/13833112827/job/38702491974

To resolve this test flakiness,

FAILED tests/hypothesis/arcticdb/test_resample.py::test_resample - AssertionError: Series are different

Series values are different (100.0 %)
[index]: [1969-12-31T23:59:01.000000000]
[left]:  [2048000.0]
[right]: [2047795.2]
At positional index 0, first diff: 2048000.0 != 2047795.2
Falsifying example: test_resample(
    lmdb_version_store_v1=NativeVersionStore: Library: test_resample.885_2025-03-13T11_31_50_948217, Primary Storage: lmdb_storage.,
    df=
                                       col_float              col_int  col_uint
        1970-01-01 00:00:00.000000000        0.0 -9223372036827825664         0
        1970-01-01 00:00:00.000000001        0.0                    0         0
        1970-01-01 00:00:00.000000002        0.0                    0         0
        1970-01-01 00:00:00.000000003        0.0                  512         0
        1970-01-01 00:00:00.000000004        0.0  9223372036838064641         0
    ,
    rule='1min',
    origin='start',
    offset='1s',
)

You can reproduce this example by temporarily adding @reproduce_failure('6.72.4', b'AXicVY2JDQAgCAMpOqp7uJ1jiXx+TcmloQEQgXzMAQ6UQPXCEb70LsxdRGYb+xKBk8WoCVWTtQScj68WvaAKUg==') as a decorator on your test case
= 1 failed, 252 passed, 10 skipped, 1 xfailed, 1 xpassed, 72587 warnings in 1132.14s (0:18:52) =

@poodlewars poodlewars added the patch Small change, should increase patch version label Mar 13, 2025
…oats

https://github.com/man-group/ArcticDB/actions/runs/13833112827/job/38702491974

To resolve this test flakiness,

```
FAILED tests/hypothesis/arcticdb/test_resample.py::test_resample - AssertionError: Series are different

Series values are different (100.0 %)
[index]: [1969-12-31T23:59:01.000000000]
[left]:  [2048000.0]
[right]: [2047795.2]
At positional index 0, first diff: 2048000.0 != 2047795.2
Falsifying example: test_resample(
    lmdb_version_store_v1=NativeVersionStore: Library: test_resample.885_2025-03-13T11_31_50_948217, Primary Storage: lmdb_storage.,
    df=
                                       col_float              col_int  col_uint
        1970-01-01 00:00:00.000000000        0.0 -9223372036827825664         0
        1970-01-01 00:00:00.000000001        0.0                    0         0
        1970-01-01 00:00:00.000000002        0.0                    0         0
        1970-01-01 00:00:00.000000003        0.0                  512         0
        1970-01-01 00:00:00.000000004        0.0  9223372036838064641         0
    ,
    rule='1min',
    origin='start',
    offset='1s',
)

You can reproduce this example by temporarily adding @reproduce_failure('6.72.4', b'AXicVY2JDQAgCAMpOqp7uJ1jiXx+TcmloQEQgXzMAQ6UQPXCEb70LsxdRGYb+xKBk8WoCVWTtQScj68WvaAKUg==') as a decorator on your test case
= 1 failed, 252 passed, 10 skipped, 1 xfailed, 1 xpassed, 72587 warnings in 1132.14s (0:18:52) =
```
@poodlewars poodlewars merged commit fe9de29 into master Mar 19, 2025
154 checks passed
@poodlewars poodlewars deleted the resample-flakiness branch March 19, 2025 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Small change, should increase patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants