Correctly handle zoneinfo timezones
#2253
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
force-pushed
the
fix-zone-info-handling
branch
7 times, most recently
from
9e52ff1 to
de8e814
Compare
Fixes #2245 Correctly normalizes zoneinfo timezones. Currently if we write something as a pytz or a ZoneInfo timezone we'll read it back as a `pytz` to preserve old pytz behavior and not break old arctic readers. Consensus is that people generally prefer `ZoneInfo` and we can change to always using `ZoneInfo` but we'll need to do so in next major release.
IvoDD
force-pushed
the
fix-zone-info-handling
branch
from
de8e814 to
da29461
Compare
IvoDD
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
G-D-Petrov
requested changes
Mar 20, 2025
| sym = "sym" | ||
| df = timestamp_indexed_df() | ||
| # We need to normalize all of these timezoned timestamps correctly and produce the correct result | ||
| metadata_to_write = [ |
There was a problem hiding this comment.
Can you add these as pytest params?
I find it a bit more clear and it helps to parallelize the execution
alexowens90
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #2245
What does this implement or fix?
Correctly normalizes zoneinfo timezones. Currently if we write something as a pytz or a ZoneInfo timezone we'll read it back as a
pytzto preserve old pytz behavior and not break old arctic readers.Consensus is that people generally prefer
ZoneInfoand we can change to always usingZoneInfobut we'll need to do so in next major release.Any other comments?
Checklist
Checklist for code changes...