Skip to content

Build MacOS Apple Silicon PyPI wheels #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 29 commits into
base: master
Choose a base branch
from
Draft

Build MacOS Apple Silicon PyPI wheels #2335

wants to merge 29 commits into from

Conversation

jjerphan
Copy link
Collaborator

Reference Issues/PRs

What does this implement or fix?

Fix #759.

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

jjerphan added 3 commits April 16, 2025 11:36
@jjerphan
Build wheels for macOS
a9890b1 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Add C++ tests for macOS
f683e14 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Add python tests for macOS
a6c6ced 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan added the patch Small change, should increase patch version label Apr 16, 2025
@jjerphan jjerphan changed the title Build MacOS Apple Silicon PyPi wheels Build MacOS Apple Silicon PyPI wheels Apr 16, 2025
@jjerphan
Implement build steps
7b615ae 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch from 7346181 to 7b615ae Compare April 16, 2025 11:33
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch from 7aafab6 to 10cce0b Compare April 16, 2025 12:14
@jjerphan
Add classifier for macOS
8b58a9e 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch from bf6d80a to 8b58a9e Compare April 16, 2025 12:57
jjerphan added 2 commits April 16, 2025 15:45
@jjerphan
Change value for checkout on submodules
32c5907 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Fetch all history and all tags
97a534d 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch 3 times, most recently from 48c8b18 to 0d3b47b Compare April 16, 2025 14:49
@jjerphan
Install bison and cmake only
a01eec8 
ninja is already installed

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch from 0d3b47b to a01eec8 Compare April 16, 2025 14:52
jjerphan added 8 commits April 17, 2025 09:21
@jjerphan
Apply patch for arrow using overlays
a5d0cdc 
Adapted from:
raulcd/arrow@fad3565

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Remove useless installation command
eb8ca4d 
CMake and Ninja are already installed at this point.

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Pick the last commit of the repository only
9898ef7 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Recursively fetch submodule
89029fb 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Use documented workaround
3bfc46e 
See: https://learn.microsoft.com/en-us/vcpkg/users/versioning-troubleshooting?WT.mc_id=vcpkg_inproduct_cli#shallow-clone-version-constraint

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Mark sources of ArcticDB as safe
4e5c3ef 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Do not use shallow repositories at all
4a64e6f 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Remove git fetch --unshallow commands
e797413 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch 3 times, most recently from be51c48 to 04631d6 Compare April 18, 2025 13:50
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch 4 times, most recently from cafa961 to eaf29db Compare April 22, 2025 07:29
jjerphan added 7 commits April 22, 2025 09:42
@jjerphan
Do not use the last state of vcpkg upstream but for Windows
dc58e26 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Do not install cmake which is already present
68a5e09 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Do not const-qualify odr-used variables in lambdas
8d29f6b 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Capture storage_config by value
06229b3 
Error message:
```
lambda capture 'storage_config' is not required to be captured for this
use [-Werror,-Wunused-lambda-capture]
```

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Specify template keyword for scalar_at
4de7762 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Disable libc++ availability for macOS
2282832 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Add constructor for FailedDelete
602b68e 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch from eaf29db to 602b68e Compare April 22, 2025 07:43
@jjerphan
Add cibuildwheel config for macos
6b55119 
In particular, make sure openssl is installed
so that it can be vendored.

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/osx-arm64-pypi-build branch from 317658a to a697da2 Compare April 24, 2025 10:52
jjerphan added 3 commits April 24, 2025 14:50
@jjerphan
Force reinstall of OpenSSL from sources
a697da2 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Set OSX deployment target to 11.0
f470516 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Move setup to workflow file instead
e596cc7 
Signed-off-by: Julien Jerphanion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 will be requested when the pull request is marked ready for review alexowens90 is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars will be requested when the pull request is marked ready for review poodlewars is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
patch Small change, should increase patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MacOS PyPi Build
1 participant
@jjerphan