Skip to content

increase file descriptors limits for tests #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/workflows/build_steps.yml
Original file line number Diff line number Diff line change
@@ -361,14 +361,28 @@ jobs:

- name: Run test
run: |
build_tooling/parallel_test.sh tests/${{matrix.type}}
echo "Persistent Storage: ${{ inputs.persistent_storage }}"
echo "Running on OS: $RUNNER_OS"

if [[ "${{ inputs.persistent_storage }}" == "GCPXML" ]]; then
if [[ "$RUNNER_OS" == "Windows" ]]; then
echo "Running Windows-specific tasks"
build_tooling/parallel_test.sh tests/${{matrix.type}}
else
echo "Running tasks for other OS"
prlimit --nofile=1000000 -- build_tooling/parallel_test.sh tests/${{matrix.type}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default file descriptor soft limit of github runner is 1048576. Giving it a lower setting can only make things worse

fi
else
build_tooling/parallel_test.sh tests/${{matrix.type}}
fi
env:
TEST_OUTPUT_DIR: ${{runner.temp}}
# Use the Mongo created in the service container above to test against
CI_MONGO_HOST: mongodb
HYPOTHESIS_PROFILE: ci_${{matrix.os}}
PYTEST_XDIST_MODE: ${{inputs.pytest_xdist_mode}}
ARCTICDB_PYTEST_ARGS: ${{inputs.pytest_args}}
RUNNER_OS: ${{ runner.os }}

- name: Collect crash dumps (Windows)
if: matrix.os == 'windows' && failure()
9 changes: 6 additions & 3 deletions python/tests/compat/arcticdb/test_lib_naming.py
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
@pytest.mark.parametrize("prefix", ["", "prefix"])
@pytest.mark.parametrize("suffix", ["", "suffix"])
@pytest.mark.storage
@pytest.mark.skip_fixture_params(["real_gcp"], "Skipped because of issues with lib names containing \\n and \\r")
@pytest.mark.skip_fixture_params(["real_gcp"], "Skipped because of issues with lib names containing \\n and \\r (8794791598)")
def test_create_library_with_all_chars(arctic_client_v1, prefix, suffix):
logger = get_logger("test_create_library_with_all_chars")
ac = arctic_client_v1
@@ -49,18 +49,21 @@ def test_create_library_with_all_chars(arctic_client_v1, prefix, suffix):
@pytest.mark.parametrize("prefix", ["", "prefix"])
@pytest.mark.parametrize("suffix", ["", "suffix"])
@pytest.mark.storage
@pytest.mark.skip_fixture_params(["real_gcp"], "Skipped because of issues with lib names containing \\n and \\r (8794791598)")
def test_symbol_names_with_all_chars(object_version_store, prefix, suffix):
# Create symbol names with each character (except '\' because Azure replaces it with '/' in some cases)
names = [f"{prefix}{chr(i)}{suffix}" for i in range(256) if chr(i) != "\\"]
df = sample_dataframe()

print("LEN: ", len(names))
written_symbols = set()
for name in names:
for i, name in enumerate(names):
try:
object_version_store.write(name, df)
written_symbols.add(name)
# We should only fail with UserInputException (indicating that name validation failed)
except UserInputException:
pass
except Exception:
print(f"Exception! name = {name} , char({i})")

assert set(object_version_store.list_symbols()) == written_symbols

Unchanged files with check annotations Beta