Upgrade gcc to 11.2 and add sparrow dependency #2355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
force-pushed
the
upgrade-gcc-11.2
branch
6 times, most recently
from
1bd1827 to
f4d3f40
Compare
IvoDD
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
alexowens90
reviewed
May 19, 2025
Upgrades both the `arcticdb_manylinux` and `arcticdb-dev` images to use gcc 11.2. This is required to be able to use sparrow 0.8.0
This requires updating the vcpkg baseline to pick up the new sparrow package. The new baseline requires extra package version pinning to make sure everything is compatible with eachother. I've made sure to not upgrade any major sdks which already had pins. This commit only adds extra pinning to make sure everything compiles.
Previous version of boost 1.84 was incompatible with gcc-11.2 for some reason. boost-regex was getting segfaults during compilation. Also removes some boost vcpkg overlayes
alexowens90
approved these changes
Jun 10, 2025
|
As per Georgi's suggestion I verified that the 3.8 and 3.11 wheels work within pegasus venvs |
G-D-Petrov
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Monday ref: 8873104825
What does this implement or fix?
This PR upgrades the manylinux image to use gcc-11.2.1 and adds the vcpkg sparrow dependency. This also required updating boost from 1.84 to 1.87.
We were using g++-10 for the manylinux2014 image.
Discussions with QS lead to deciding that we should upgrade compiler to
gcc 11.2.1 to be able to compile sparrow 0.8.0.
Adding the sparrow dependency required updating the vcpkg baseline to pick up the new package.
The new baseline requires extra package version pinning to make sure everything is compatible with eachother. I've made sure to not upgrade any major sdks which already had pins.
This PR only updates the version of boost from 1.84 to 1.87 to resolve a compilation issue with boost-regex. The boost upgrade is in a separate commit.
Any other comments?
Successful CI run from this branch's
Build and Testworkflow here. It uses the updated arcticdb-dev docker image for the c++ tests instead of the clang one.Successful CI run of
Build with analisys toolshere.Checklist
Checklist for code changes...