Skip to content

Customizable Run conda tests workflow #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 10, 2025
Merged

Customizable Run conda tests workflow #2386

merged 10 commits into from
Jun 10, 2025

Conversation

grusev
Copy link
Collaborator

@grusev grusev commented Jun 5, 2025

Reference Issues/PRs

What does this implement or fix?

Idea is same as with #2379

The actual PR is also for "test_diff_long_stream_descriptor_mismatch" test on MacOS which used to be flaky. No more such evidences. But to prove that we need also MacOS builds that allow tests for flakyness

The new workflow gives option to run or not cpp tests as well as to pass aditional arguments to pytest or completely rewrite pytest command to be able to achieve repetitions to test for flakyness. Example:

 pytest -n auto -v --count=100 -x python/tests/integration/arcticdb/test_storage_lock.py

Test on MacOS
Test: python/tests/integration/arcticdb/version_store/test_basic_version_store.py::test_diff_long_stream_descriptor_mismatch
Command: pytest -n 10 -v --count=1000 -x python/tests/integration/arcticdb/version_store/test_basic_version_store.py::test_diff_long_stream_descriptor_mismatch
Log: https://github.com/man-group/ArcticDB/actions/runs/15462578452
Analysis: the test executed ok on mac_os without any errors

More advanced test:
Command: pytest -n auto -v --count=2000 -x python/tests/integration/arcticdb/version_store/test_basic_version_store.py::test_diff_long_stream_descriptor_mismatch
Log: https://github.com/man-group/ArcticDB/actions/runs/15530261173/job/43717520944

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@grusev grusev added the patch Small change, should increase patch version label Jun 5, 2025
@grusev grusev merged commit 0876bf2 into master Jun 10, 2025
142 of 149 checks passed
@grusev grusev deleted the test_macos_flakyness branch June 10, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Small change, should increase patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants