Rework C++ truncation for arrow #2387
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
force-pushed
the
read_as_arrow
branch
2 times, most recently
from
65d4e59 to
bef748c
Compare
IvoDD
force-pushed
the
rework-cpp-truncation
branch
from
6f33a19 to
2ecfee1
Compare
Arrow requires truncation to happen in C++ layer. Previous logic had many issues: - Wrong truncated range calculation - Wrong offsets used when first row offset != 0 - Wrong row range calculation This PR fixes the issues by rewriting a lot of the column truncation logic and adds more tests.
IvoDD
force-pushed
the
rework-cpp-truncation
branch
from
2ecfee1 to
d28b7a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday ref: 9320469407
Arrow requires truncation to happen in C++ layer.
Previous logic had many issues:
This PR fixes the issues by rewriting a lot of the column truncation logic and adds more tests.
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...