Skip to content

Add asv benchmarks for Azure Storage #2389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add asv benchmarks for Azure Storage #2389

wants to merge 3 commits into from
+221 −22

Conversation

jjerphan
Copy link
Collaborator

@jjerphan jjerphan commented Jun 6, 2025

Reference Issues/PRs

See #2282 (comment).

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@jjerphan jjerphan added the patch Small change, should increase patch version label Jun 6, 2025
@jjerphan jjerphan force-pushed the asv/AzureReadWrite branch from 3f523c8 to ed0c54a Compare June 6, 2025 13:15
jjerphan added 2 commits June 6, 2025 15:16
@jjerphan
Add asv benchmarks for Azure Storage
ed0c54a 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Adapt environment setup for Azure
68d1f2a 
Signed-off-by: Julien Jerphanion <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 6, 2025
View reviewed changes
.github/workflows/analysis_workflow.yml Outdated
Comment on lines 54 to 70
needs: [get_commits_to_benchmark]
strategy:
fail-fast: false
matrix:
commits: ${{ fromJson(needs.get_commits_to_benchmark.outputs.matrix)}}
matrix:
commits: ${{ fromJson(needs.get_commits_to_benchmark.outputs.matrix)}}
name: Benchmark commit ${{ matrix.commits }}
uses: ./.github/workflows/benchmark_commits.yml
secrets: inherit
with:
commit: ${{ matrix.commits }}
run_all_benchmarks: ${{ inputs.run_all_benchmarks || false }}
run_on_pr_head: ${{ github.event_name == 'pull_request_target' }}
dev_image_tag: ${{ inputs.dev_image_tag || 'latest' }}
suite_to_run: ${{ github.event_name == 'schedule' && 'ALL' || inputs.suite_to_run || 'LMDB'}}
suite_overwrite: ${{ inputs.suite_overwrite || ''}}

publish_benchmark_results_to_gh_pages:
publish_benchmark_results_to_gh_pages:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI 5 days ago

To fix the issue, we need to add a permissions block to the benchmark_commits job. This block should specify the minimal permissions required for the job to function correctly. Since the job primarily delegates tasks to another workflow and does not directly interact with repository contents or other sensitive resources, the permissions can likely be limited to contents: read.

The permissions block should be added directly under the benchmark_commits job definition, ensuring that the job does not inherit overly permissive repository-level permissions.

Suggested changeset 1
.github/workflows/analysis_workflow.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/analysis_workflow.yml b/.github/workflows/analysis_workflow.yml
--- a/.github/workflows/analysis_workflow.yml
+++ b/.github/workflows/analysis_workflow.yml
@@ -54,2 +54,4 @@
     needs: [get_commits_to_benchmark]
+    permissions:
+      contents: read
     strategy:
EOF
@@ -54,2 +54,4 @@
needs: [get_commits_to_benchmark]
permissions:
contents: read
strategy:
Copilot is powered by AI and may make mistakes. Always verify output.
@jjerphan jjerphan force-pushed the asv/AzureReadWrite branch 2 times, most recently from 80899f9 to 1a9f3dd Compare June 6, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 will be requested when the pull request is marked ready for review alexowens90 is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars will be requested when the pull request is marked ready for review poodlewars is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
patch Small change, should increase patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jjerphan