Additional fix for missing pandas.Panel#887
Additional fix for missing pandas.Panel#887enricodetoma wants to merge 17 commits intoman-group:masterfrom
Conversation
|
@enricodetoma you need to rebase off the latest master after pinning pandas and numpy |
|
@shashank88 I rebased off the latest master, but I'm not sure what you mean about pinning pandas and numpy. |
|
Actually I'm already using Arctic successfully with pandas 1.2.3 with this change, without Panel support |
Same here, using it with latest Pandas. I don't use panels explicitly, just using tick store. Chunk store too slow to use. |
|
Any update on this review? |
dunckerr
left a comment
There was a problem hiding this comment.
Hi Enrico - we haven’t removed Panel support because we are still supporting old versions of Pandas. Am I correct that you’re forking arctic repo and removing Panel support? We are always interested to hear about any improvements to the arctic codebase.
Thanks
Duncan
|
Hi Duncan, I'm simply skipping importing Panel if it doesn't exist: |
# Conflicts: # arctic/__init__.py # setup.py
I made an additional fix to manage the case of missing
Panelin newpandasversions.In fact I discovered that in few cases (e.g.
library.delete(symbol)),PandasPanelStorestatic methodcan_write_typewas still called.With this commit,
PandasPanelStoreis not even registered as storage class ifPanelis missing frompandas.