Skip to content

Fix update attempt refreshing pill without actually updating #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 3 commits into from
Mar 25, 2026
Merged

Fix update attempt refreshing pill without actually updating #2168

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cd842d
Fix update attempt refreshing pill without actually updating
lawrencecchen Mar 25, 2026
e450afe
Revert "Fix update attempt refreshing pill without actually updating"
lawrencecchen Mar 25, 2026
ad5e591
Fix update attempt refreshing pill without actually updating
lawrencecchen Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Sources/Update/UpdateController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,10 @@ class UpdateController {
return
}

guard self.didObserveAttemptUpdateProgress, !state.isInstallable else {
// Only stop on terminal failure states (.notFound, .error).
// Don't stop on .idle — the check may still be starting up
// (e.g. retry loop, background probe finishing).
guard self.didObserveAttemptUpdateProgress, !state.isInstallable, !state.isIdle else {
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Stop attempt monitor when state settles back to idle

This new guard excludes .idle from terminal states, so attemptInstallCancellable is never cleared when an attempted install path returns to idle (for example after cancel/restart-later). In that case the subscriber keeps running indefinitely and will still auto-confirm() any future .updateAvailable, which can make a later normal update check install automatically without fresh user intent. Please keep the transient-idle protection for startup races, but still tear down monitoring once an attempt has progressed and then comes back to idle.

Useful? React with 👍 / 👎.

return
}
self.stopAttemptUpdateMonitoring()
Expand Down
Loading