Skip to content

fix: emoji input blocked in command palette rename #2291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pandec wants to merge 3 commits into from
Closed

fix: emoji input blocked in command palette rename #2291

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8f1b4b
Fix emoji input in command palette rename
pandec Mar 28, 2026
f9ae7c0
chore: trim emoji rename fix scope
pandec Mar 28, 2026
0b07651
fix: restore rename placeholder and single-line behavior
pandec Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/AppDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,8 +1684,7 @@ func shouldSubmitCommandPaletteWithReturn(
}

func commandPaletteFieldEditorHasMarkedText(in window: NSWindow) -> Bool {
guard let editor = window.firstResponder as? NSTextView,
editor.isFieldEditor else {
guard let editor = window.firstResponder as? NSTextView else {
return false
}
return editor.hasMarkedText()
Expand Down
Loading