-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Keep prompt colors when switching local TERM to xterm-256color #2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
cdccc56
test: cover zsh startup term handoff
lawrencecchen a3172f1
fix: keep prompt colors with xterm-256color
lawrencecchen e84537e
Merge remote-tracking branch 'origin/main' into feat-term-xterm-256color
lawrencecchen b13e332
fix: drop unsupported Ghostty focus seed
lawrencecchen 48f1895
fix: restore GhosttyKit-compatible submodule pointers
lawrencecchen af6a3ad
test: cover zsh term handoff edge cases
lawrencecchen 9583579
fix: guard zsh term spoof and sync ghostty fork docs
lawrencecchen d4194e9
fix: suppress missing zle hook noise
lawrencecchen 6a32f83
test: cover user zshenv integration disable
lawrencecchen 8211f33
fix: honor user zshenv integration disables
lawrencecchen 225b492
test: cover zsh preexec term restore
lawrencecchen 468ced0
fix: restore zsh term in preexec
lawrencecchen c9fa79f
test: drive zsh handoff through a pty
lawrencecchen 4cbee67
test: fail fast in pty zsh helper
lawrencecchen e1e3841
Merge remote-tracking branch 'origin/main' into feat-term-xterm-256color
lawrencecchen d6853e1
test: buffer pty output incrementally
lawrencecchen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,14 @@ | ||
| # cmux terminfo overlay | ||
|
|
||
| cmux ships Ghostty's `xterm-ghostty` terminfo entry, but the embedded | ||
| renderer in cmux has differed from Ghostty's app renderer in how it treats | ||
| the "bright" SGR 90-97/100-107 sequences. | ||
| cmux ships patched `xterm-ghostty` and `xterm-256color` terminfo entries so | ||
| the embedded renderer keeps the same color behavior even when the reported | ||
| `TERM` changes. | ||
|
|
||
| This overlay patches the terminfo capabilities so that `tput setaf 8` (and | ||
| These overlays patch the terminfo capabilities so that `tput setaf 8` (and | ||
| similar "bright" colors) uses 256-color indexed sequences (`38;5;<n>m` / | ||
| `48;5;<n>m`) rather than SGR 90-97/100-107. This avoids relying on bright SGR | ||
| handling and fixes zsh-autosuggestions (default `fg=8`) visibility issues in | ||
| cmux. | ||
| cmux while preserving Ghostty's truecolor capabilities. | ||
|
|
||
| The build phase `Copy Ghostty Resources` overlays this directory onto the app | ||
| bundle's `Contents/Resources/terminfo` after copying Ghostty's resources. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.