feat(i18n): complete Korean website translations (100%)#2932
feat(i18n): complete Korean website translations (100%)#2932say8425 wants to merge 2 commits intomanaflow-ai:mainfrom
Conversation
|
@say8425 is attempting to deploy a commit to the Manaflow Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughUpdated Korean localization ( Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds 222 missing Korean ( Confidence Score: 5/5Safe to merge — pure translation file, no logic changes, all structural invariants verified programmatically. All 822 keys present and matching en.json structure, JSON is valid, zero placeholder or tag mismatches, proper nouns correctly left untranslated. No code changes outside the translation file. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["web/messages/en.json\n(822 keys — source of truth)"] --> B{Key diff check}
C["web/messages/ko.json\n(before PR: 600/822 keys)"] --> B
B --> D["Missing: 222 keys\n(blog posts, SSH docs, agent integration docs,\nkeyboard shortcut chords, wall-of-love metadata)"]
D --> E["PR #2932\nAdd 222 Korean translations"]
E --> F["web/messages/ko.json\n(after PR: 822/822 keys ✓)"]
F --> G{Validation}
G --> H["Placeholder check\n{year}, {configPath}, etc. ✓"]
G --> I["HTML-tag check\n<link>, <code>, <nightly> ✓"]
G --> J["JSON validity ✓"]
G --> K["Structure parity ✓"]
Reviews (1): Last reviewed commit: "feat(i18n): complete Korean website tran..." | Re-trigger Greptile |
Add 222 missing Korean translations to web/messages/ko.json,
bringing coverage from 600/822 keys (73%) to 822/822 (100%).
Missing sections translated:
- Blog: 4 posts (cmux Claude Teams, cmux OMO, GPL, cmux SSH)
- Docs: oh-my-claudecode, ohMyCodex, ohMyOpenCode, claudeCodeTeams
- Docs: SSH guide, configuration, keyboard shortcuts (chords)
- Wall of Love metadata
All placeholders ({year}, {configPath}, etc.) and HTML-like tags
(<link>, <configPath>, etc.) preserved. Formal tone consistent
with existing translations.
say8425
force-pushed
the
feat/i18n-korean-web-translations
branch
from
8b2077f to
d230fde
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@web/messages/ko.json`:
- Around line 869-875: The "agentIntegrations" entry in the Korean messages file
is still in English; update the value for the "agentIntegrations" key in
web/messages/ko.json to the appropriate Korean translation (matching surrounding
localized entries), e.g., replace "Agent Integrations" with the Korean string
for agent integrations so the /ko sidebar is fully localized.
- Around line 347-350: The term "코드 단축키" is confusing; update the
"settingsFileChords" message to use a clearer Korean term such as "다단계 단축키" (or
"연속 단축키/다단계 키 조합") and reword the sentence accordingly to describe a prefix +
follow-up key (e.g., "[\"ctrl+b\", \"c\"]는 Ctrl+B를 누른 다음 C를 누르는 것을 의미합니다"); also
search and replace any other occurrences of the exact phrase "코드 단축키" elsewhere
in this file (including the similar wording around lines 422-427) so all
keys/messages use the new clearer term.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
- "코드 단축키" → "2단계 단축키(chord)" — clearer term for key chords - "Agent Integrations" → "에이전트 통합" — translate mixed-language label
There was a problem hiding this comment.
♻️ Duplicate comments (1)
web/messages/ko.json (1)
422-424:⚠️ Potential issue | 🟡 MinorUse one consistent Korean term for “chord” in shortcuts docs.
"단축키 코드"/"두 단계 단축키 코드"is still ambiguous. Please align this header/intro with the clearer wording already used in this file (2단계 단축키(chord)), so terminology is consistent across docs.💡 Suggested wording
- "chordsTitle": "단축키 코드", - "chordsIntro": "cmux는 <settingsFile>~/.config/cmux/settings.json</settingsFile>에서 두 단계 단축키 코드를 지원합니다. 전체 설정 파일 스키마는 <configurationLink>설정 문서</configurationLink>를 참조하세요.", + "chordsTitle": "2단계 단축키", + "chordsIntro": "cmux는 <settingsFile>~/.config/cmux/settings.json</settingsFile>에서 2단계 단축키(chord)를 지원합니다. 전체 설정 파일 스키마는 <configurationLink>설정 문서</configurationLink>를 참조하세요.",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@web/messages/ko.json` around lines 422 - 424, Update the Korean terminology for chords to match the file's preferred phrasing: replace the values of keys "chordsTitle", "chordsIntro", and "chordsCallout" to use "2단계 단축키(chord)" (and "2단계 단축키" where used in sentences) so the header/intro/callout consistently refer to 2단계 단축키(chord) across the document.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@web/messages/ko.json`:
- Around line 422-424: Update the Korean terminology for chords to match the
file's preferred phrasing: replace the values of keys "chordsTitle",
"chordsIntro", and "chordsCallout" to use "2단계 단축키(chord)" (and "2단계 단축키" where
used in sentences) so the header/intro/callout consistently refer to 2단계
단축키(chord) across the document.
1 participant
Summary
Add 222 missing Korean translations to
web/messages/ko.json, bringing coverage from 600/822 keys (73%) to 822/822 (100%).Translation scope
Changes
web/messages/ko.json: 222 new translation entries (+290 lines)Quality checks
, etc.)Test plan
web/messages/ko.jsonis valid JSON and loads with next-intlReview Trigger
Summary by cubic
Complete Korean website translations by adding 222 strings to
web/messages/ko.json(822/822, 100% coverage), covering four blog posts; docs for SSH, Claude Code Teams, andoh-my-*; keyboard‑shortcut chords + configuration; docs nav and community/blog/Wall of Love metadata. Follow‑up fixes clarify key‑chord terminology to “2단계 단축키(chord)” and localize the “Agent Integrations” nav to “에이전트 통합”; no other files changed.Written for commit 5da05d4edc25aaa29ecba2e7a33c1633f5351ee6. Summary will update on new commits.
Summary by CodeRabbit
New Features
Documentation
Chore