Conversation
📝 WalkthroughWalkthroughUpdated the ghostty submodule to commit Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant Search as Search Engine
participant Page as Page/Screen
participant Formatter as Formatter
participant Test as Regression Test
Client->>Search: initiate search across pages
Search->>Page: snapshot page contents (copy nodes & rows)
Page-->>Search: return snapshot
Search->>Formatter: request formatting on snapshot
Formatter-->>Search: return formatted chunks + cached rows
Search->>Test: validate matches (including cross-page)
Test->>Page: destroy source screen (simulated)
Search-->>Client: return validated matches (no deref of original nodes)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@ghostty`:
- Line 1: Ensure the submodule commit 641d58aed1c28ad284036e240a1f577ffb9f58d2
is pushed to your fork's origin/main so the submodule reference is reachable
from origin/main, then rebuild the GhosttyKit artifact and add the resulting
checksum entry to scripts/ghosttykit-checksums.txt (use the exact commit hash
and artifact name in the entry) before updating the PR; this ensures the
submodule reference is available and the checksum file contains a matching
record.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 04793ad8-3aae-4a4a-b8e3-025c4926cedb
📒 Files selected for processing (2)
docs/ghostty-fork.mdghostty
| @@ -1 +1 @@ | |||
| Subproject commit 3b684a085d40ec79e8a0ae863a4f2b48ed4dba74 | |||
| Subproject commit a2f864d614b5318bb0d1476d12c18d787d6033bf | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
ghostty_commit="$(git -C ghostty rev-parse HEAD)"
echo "Ghostty submodule commit: ${ghostty_commit}"
echo "Checking checksum entry..."
grep -F "${ghostty_commit}" scripts/ghosttykit-checksums.txt
echo "Checking submodule commit is on origin/main..."
git -C ghostty merge-base --is-ancestor HEAD origin/mainRepository: manaflow-ai/cmux
Length of output: 153
Push the Ghostty commit to origin/main and add the matching checksum entry.
The submodule now points to 641d58aed1c28ad284036e240a1f577ffb9f58d2, which is not reachable from origin/main and has no entry in scripts/ghosttykit-checksums.txt. Per submodule workflow requirements, push the commit to the fork's origin/main branch first, then add the checksum for the rebuilt GhosttyKit artifact.
🧰 Tools
🪛 GitHub Actions: Build GhosttyKit
[error] CI step failed: 'zig build -Demit-xcframework=true -Demit-macos-app=false -Dxcframework-target=universal -Doptimize=ReleaseFast' exited with code 1.
🪛 GitHub Actions: CI
[error] 1-1: FAIL: scripts/ghosttykit-checksums.txt is missing an entry for ghostty a2f864d614b5318bb0d1476d12c18d787d6033bf
[error] 1-1: Command failed with exit code 1.
🪛 GitHub Actions: macOS Compatibility
[error] 1-1: Missing pinned GhosttyKit checksum for ghostty a2f864d614b5318bb0d1476d12c18d787d6033bf in /Users/runner/work/cmux/cmux/scripts/ghosttykit-checksums.txt
[error] 1-1: Step failed: ./scripts/download-prebuilt-ghosttykit.sh (Process completed with exit code 1)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@ghostty` at line 1, Ensure the submodule commit
641d58aed1c28ad284036e240a1f577ffb9f58d2 is pushed to your fork's origin/main so
the submodule reference is reachable from origin/main, then rebuild the
GhosttyKit artifact and add the resulting checksum entry to
scripts/ghosttykit-checksums.txt (use the exact commit hash and artifact name in
the entry) before updating the PR; this ensures the submodule reference is
available and the checksum file contains a matching record.
Greptile SummaryThis PR bumps the Ghostty submodule from
Confidence Score: 4/5Mostly safe to merge, but the submodule pin label suggests the commit may be on a feature branch rather than the fork's main, which violates CLAUDE.md's submodule safety policy and risks the SHA becoming unreachable. One P1 concern: the fork pin label docs/ghostty-fork.md — verify the pinned commit is reachable from manaflow/main before merging. Important Files Changed
Sequence DiagramsequenceDiagram
participant R as resizeCols (main thread)
participant S as SlidingWindow (search bg)
participant P as PageList storage
Note over R,P: BEFORE fix – race condition
R->>P: free / recycle page storage
S->>P: PageFormatter reads live page (use-after-free)
P-->>S: ❌ freed / recycled memory
Note over R,P: AFTER fix – snapshot isolation
S->>P: snapshot page contents (copy)
S->>S: cache page row counts in flattened chunks
R->>P: free / recycle page storage (safe)
S->>S: PageFormatter reads snapshot (not live storage)
S->>S: highlight assembly reads cached row counts
Note over S: ✅ no live-page dereference after screen mutation
Reviews (1): Last reviewed commit: "Fix Ghostty search resize race" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| Fork main has advanced beyond the March 30, 2026 rebase onto upstream `main` | ||
| at `3509ccf78` (`v1.3.1-457-g3509ccf78`). | ||
| Current cmux pinned fork head: `3b684a085` (`tip-1717-g3b684a085`). | ||
| Current cmux pinned fork head: `a2f864d61` (`issue-2738-search-resize-race`). |
There was a problem hiding this comment.
The previous pinned head was labeled tip-1717-g3b684a085 — a git describe output indicating a position on the fork's main. The new label issue-2738-search-resize-race does not follow that TAG-N-gHASH pattern and looks like a feature-branch name.
Per the CLAUDE.md submodule safety policy: "always push the submodule commit to its remote main branch BEFORE committing the updated pointer … Never commit on a detached HEAD or temporary branch — the commit will be orphaned and lost." If this commit is only on the issue-2738-search-resize-race branch and that branch is later deleted, the submodule SHA a2f864d61 could become unreachable for future git submodule update calls.
Please confirm git merge-base --is-ancestor a2f864d614b5318bb0d1476d12c18d787d6033bf manaflow/main passes, and update the pin label to the git describe form from manaflow/main if it does.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="ghostty">
<violation number="1" location="ghostty:1">
P1: The submodule is pinned to commit `a2f864d61` which is not reachable from `origin/main` and has no corresponding entry in `scripts/ghosttykit-checksums.txt`. CI is failing across multiple jobs (Build GhosttyKit, CI checksum validation, macOS Compatibility). Push this commit to the fork's `main` branch and add the matching checksum entry before merging.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
Summary
resizeColshas freed or recycleddocs/ghostty-fork.mdwith the new fork pin and conflict notes for the retained-page search pathTesting
Notes
Note
Low Risk
Low risk: this PR only updates documentation and the GhosttyKit checksum mapping to reflect a new pinned Ghostty fork head; no runtime code changes in this repo.
Overview
Updates the pinned Ghostty fork reference to
e36dd9d50and documents the new search snapshot isolation change set that prevents retained search/highlight from reading page storage that can be freed/recycled during resize.Refreshes merge-conflict notes for the retained-page search path and adds the corresponding
GhosttyKit.xcframeworkchecksum entry for the new submodule SHA.Reviewed by Cursor Bugbot for commit eecb27a. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Fixes a race between search/highlight and terminal resize by isolating search from live page storage. Updates the
ghosttysubmodule and pinsGhosttyKitchecksums to support the snapshot-based search path (addresses issue-2738).Bug Fixes
resizeColscan free or recycle.Dependencies
ghosttysubmodule and updatedocs/ghostty-fork.mdwith the new pin, snapshot notes, and conflict guidance; includes a regression test for retained search after screen teardown.GhosttyKitchecksum inscripts/ghosttykit-checksums.txtfor the snapshot fix.Written for commit eecb27a. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
Documentation
Tests
Chores