Skip to content

Fix MessagePack message size determination #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephtr
Copy link

@stephtr stephtr commented May 29, 2024

The algorithm for determining the size of MessagePack messages was wrong. The size is not encoded in the msgpack format, but distributed over the first few bytes (until the first one with the 0x80 bit set).
For messages smaller than 128 bytes, this doesn't make a difference, but for larger messages, the function failed.
I took the implementation from the official JS client and ported it to python.

@Ge0
Copy link

Ge0 commented Jan 20, 2025

@mandrewcito Hello! You may want to check this PR out, as I have come across the same issue as @stephtr and that I patched it myself to make it work with variable-length integers.

It would be great if this bugfix was added to the next version available on pip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants