Fix MessagePack message size determination #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mandrewcito Hello! You may want to check this PR out, as I have come across the same issue as @stephtr and that I patched it myself to make it work with variable-length integers. It would be great if this bugfix was added to the next version available on pip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm for determining the size of MessagePack messages was wrong. The size is not encoded in the msgpack format, but distributed over the first few bytes (until the first one with the 0x80 bit set).
For messages smaller than 128 bytes, this doesn't make a difference, but for larger messages, the function failed.
I took the implementation from the official JS client and ported it to python.