Fixing autocomplete and adding citation extraction #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mangecoeur
reviewed
Dec 28, 2021
| @@ -156,14 +159,16 @@ def get_settings(setting, default): | |||
| if setting == 'bibtex_file': | |||
| window = sublime.active_window() | |||
| ref_dir = os.path.dirname(window.project_file_name()) | |||
| result = ref_dir + '/' + project_data['bibtex_file'] | |||
| filename = project_data['bibtex_file'] | |||
| result = ref_dir + '/' + filename.replace('\'', '') | |||
There was a problem hiding this comment.
I think this will fail on windows - need to use os.path.join (or work with pathlib but that's probably overkill)
|
Hi thanks for the PR, I just had a look and I left a comment - there is a case of joining paths that I think will fail on windows. Could you please check the comment and resolve thanks :) |
|
Sry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some additional quotes the code that updates the cached citation keys did not work anymore (bibfile_modifed and load_bibfile).
Additionally, I added some code to extract the used citation entries. This is dne using some GPL code provided by
Joseph Reagle.