Fix wrong order of parameter expansion#1
Open
IMFJS wants to merge 1 commit into
Open
Conversation
Since some time (unfortunately, I could not figure out why or since when exactly) the script stopped working. It turned out that the $p variable had been empty inside the "cd" and "%my_app%" commands after being defined in the launch command. After some fiddling, it became clear that $p was being expanded too early and in the same context as the "bash -i -c" command before "bash -i -c" even started its work. This is solved by escaping the parameter expansion (as well as the sub-shells inside the launch command) once with a backslash. Also see the added comment part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some time (unfortunately, I could not figure out why or since when exactly) the script stopped working. It turned out that the $p variable had been empty inside the "cd" and "%my_app%" commands after being defined in the launch command. After some fiddling, it became clear that $p was being expanded too early and in the same context as the "bash -i -c" command before "bash -i -c" even started its work. This is solved by escaping the parameter expansion (as well as the sub-shells inside the launch command) once with a backslash. Also see the added comment part.