ci: move the msstore CLI pin off v0.3.9 now that #162 is released - #266
Merged
Merged
Conversation
…eleased The pin sat on v0.3.9 because v0.4.0 and v0.4.1 cancelled every Azure blob upload: --uploadTimeout was added with a CustomParser but no DefaultValueFactory, so omitting it left the value at default(long) -- 0 -- which became the blob client's NetworkTimeout (microsoft/msstore-cli#162). The comment set the exit condition as "move off v0.3.9 only once a release later than v0.4.1 exists". msstore-cli v0.4.2 shipped on 2026-09-02 carrying the fix (mangokingTW#163), so that condition is met. Only the pin and its comment change; the submit step is untouched. mangokingTW#161 (success logs to stderr) is still open, so that workaround stays. mangokingTW#150 was also fixed in v0.4.2 via mangokingTW#158, which makes the JSON rejoin redundant but harmless -- left alone to keep this to the pin. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a33ffb27-8072-43c0-beb7-a7bc7e8e2229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comment on this pin set its own exit condition:
msstore-cli v0.4.2 shipped on 2026-09-02, so that condition is met. This moves the pin and rewrites the comment; the submit step is untouched.
What this is not
This is deliberately not a revert of #243. That PR only replaced a wrong root-cause guess with the correct one — reverting it would restore a worse comment. The actual workaround here was the pin to
v0.3.9, and that is what changes.What v0.4.2 fixes for this workflow
--uploadTimeouthad aCustomParserbut noDefaultValueFactory, so omitting it leftdefault(long)—0— as the blob client'sNetworkTimeout.What stays
-join ''rejoin for feat: implement Sidecar Helper architecture for WinUI/TSF support (v1.5.0) #150 is now redundant but harmless — joining unwrapped lines still yields valid JSON — so it is left alone to keep this change scoped to the pin. Removing it can be a separate cleanup.Sizing note
At ~0.7 MB the
.msixbundleis far inside the CLI's 100 s default, so nothing needs--uploadTimeouthere.Sent as part of a sweep across the repos that referenced msstore-cli#162.