Skip to content

Fix/set valid tag#2

Closed
manhatsu wants to merge 5 commits into
doc/no-uninit-valuefrom
fix/set-valid-tag
Closed

Fix/set valid tag#2
manhatsu wants to merge 5 commits into
doc/no-uninit-valuefrom
fix/set-valid-tag

Conversation

@manhatsu

@manhatsu manhatsu commented Dec 5, 2025

Copy link
Copy Markdown
Owner

Patch for this PR.
The build was successful in my local environment.

manhatsu and others added 5 commits December 5, 2025 08:41
Updated guidelines on uninitialized memory usage and added examples of compliant and non-compliant code.
Added noncompliant and compliant examples demonstrating safe /unsafe memory initialization in Rust.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes invalid tag usage and resolves a duplicate ID in the coding guidelines documentation. The changes ensure the build succeeds by replacing the non-existent "unsafe" tag with valid "safety" and "security" tags, and by generating a unique ID for a compliant example that was previously duplicated.

  • Replaced invalid "unsafe" tag with valid "safety" and "security" tags
  • Changed duplicate compliant_example ID to a unique identifier

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PLeVasseur

Copy link
Copy Markdown
Collaborator

Was this attempting to add tags as @rcseacord did on this PR?
Safety-Critical-Rust-Consortium#238

Note that it's necessary to add the tag to src/conf.py

@manhatsu

manhatsu commented Dec 5, 2025

Copy link
Copy Markdown
Owner Author

Was this attempting to add tags as @rcseacord did on this PR? rustfoundation#238

Note that it's necessary to add the tag to src/conf.py

I found I misunderstood your intention. I'll make a new PR.

@manhatsu

manhatsu commented Dec 8, 2025

Copy link
Copy Markdown
Owner Author

I solved this issue in another PR so I'm closing this.

@manhatsu manhatsu closed this Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants