fix: release nested freezes after backup failure - #140
Open
sanikolaev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents a failed backup from leaving an RT table frozen when an error occurs after its per-table
FREEZE.Follow-up to #138.
How to reproduce manually
Root cause
Backup freezes tables twice:
FREEZEprotects all selected tables.If a frozen file disappears before it is processed, such as an exceptions file,
filesize()throws before the per-tableUNFREEZEis reached.The existing shutdown cleanup releases only one freeze level, leaving the affected table locked with
Count: 1.Fix
Wrap the work following the per-table
FREEZEintry/catch/finally:finally.This balances both freeze levels without querying
SHOW LOCKSin production.Test
Added a regression test that:
filesize(): stat failederror.SHOW LOCKScontains no lock for the table.