Skip to content

Conversation

@gfazioli
Copy link
Contributor

β€’ Removing the incompatible dark mode addon: Since [email protected] is not yet compatible with Storybook v9, I: β€’ Removed the package: yarn remove storybook-dark-mode
β€’ Removed it from .storybook/main.ts configuration
β€’ Cleaned up the dark mode integration code from .storybook/preview.tsx

Current package versions after update:

β€’ storybook: ^9.0.18 βœ…
β€’ @storybook/react-vite: ^9.0.18 βœ…
β€’ @storybook/addon-docs: ^9.0.18 βœ…
β€’ All packages are now on compatible v9 versions

…types error

β€’ Removing the incompatible dark mode addon: Since [email protected] is not yet compatible with Storybook v9, I:
β€’  Removed the package: yarn remove storybook-dark-mode
β€’  Removed it from .storybook/main.ts configuration
β€’  Cleaned up the dark mode integration code from .storybook/preview.tsx

Current package versions after update:

β€’  storybook: ^9.0.18 βœ…
β€’  @storybook/react-vite: ^9.0.18 βœ…
β€’  @storybook/addon-docs: ^9.0.18 βœ…
β€’  All packages are now on compatible v9 versions
Copilot AI review requested due to automatic review settings July 22, 2025 13:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Storybook package compatibility issues by upgrading all Storybook packages to v9.0.18 and removing the incompatible dark mode addon. The changes resolve type errors caused by version mismatches between different Storybook packages.

  • Updates all Storybook packages to consistent v9.0.18 versions
  • Removes incompatible storybook-dark-mode addon and related configuration
  • Adds eslint-plugin-storybook for better Storybook linting support

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updates Storybook packages to v9.0.18 and removes storybook-dark-mode
eslint.config.mjs Adds Storybook ESLint plugin configuration
docs/package.json Updates @tabler/icons-react dependency
.storybook/preview.tsx Removes dark mode integration code and simplifies configuration
.storybook/main.ts Removes dark mode addon and updates configuration structure

@rtivital
Copy link
Member

Not sure what this fixes, just removes one of the most important features of storybook.

@gfazioli
Copy link
Contributor Author

@rtivital looks like that the "storybook-dark-mode" not working with storybook v9 atm
image

the other way is downgrade to v8

@rtivital
Copy link
Member

Yeah for now It is better to downgrade to v8 storybook for now

@gfazioli
Copy link
Contributor Author

@rtivital This means you will update the "extension-template"? Because currently, if you fork it, Storybook does not work

@rtivital
Copy link
Member

rtivital commented Aug 5, 2025

I've downgraded the storybook to v8, thanks for reporting

@rtivital rtivital closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants