[@mantine/hooks] use-media-query: Catch matchMedia errors when reading the initial value synchronously#9020
Open
mahirhir wants to merge 1 commit into
Conversation
…g the initial value synchronously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8189 fixed a Safari crash where
window.matchMediaexists but throws when called inside a cross-origin iframe. That PR wrapped the call inside the effect in atry/catch, but the same call ingetInitialValuewas left unguarded:getInitialValueruns during render when a consumer passes{ getInitialValueInEffect: false }(used to read the value synchronously and avoid a flash on first paint). The'matchMedia' in windowcheck only confirms the method exists, which is exactly the case in the Safari iframe scenario, so the call still throws and crashes the render. The effect path no longer crashes after #8189, but this synchronous path does.The fix mirrors #8189: wrap the call in
try/catchand fall back tofalse.Added a test that makes
matchMediathrow and renders withgetInitialValueInEffect: false. Without the change the render throws; with it the hook returnsfalse.