[@mantine/core] ColorInput: Add support for fullWidth prop#9061
Open
saadpocalypse wants to merge 3 commits into
Open
[@mantine/core] ColorInput: Add support for fullWidth prop#9061saadpocalypse wants to merge 3 commits into
saadpocalypse wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ColorPickercomponent supports taking 100% width of its container using thefullWidthprop. However, when renderingColorPickerwithin aColorInputdropdown, there was no way to pass thefullWidthprop fromColorInputdown to the picker. Additionally, because the popover dropdown haswidth: 'max-content'by default, passing a 100% width constraint directly to the child color picker caused the layout to collapse.Solution
fullWidthprop fromColorPickerPropsto__ColorPickerPropsso that it is properly inherited byColorInputProps.fullWidthfromColorInputto the internal<ColorPicker />component.width={fullWidth ? 'target' : undefined}to the<Popover />wrapper insideColorInputso that the dropdown matches the target input's width and prevents the picker layout from collapsing.Tests
ColorInput.test.tsxto verify that passingfullWidthtoColorInputcorrectly applies thedata-full-widthattribute to the underlying picker wrapper inside the dropdown.FullWidthstory inColorInput.story.tsxwithpopoverProps={{ opened: true }}to demonstrate the color picker expanding to the full width of the input dropdown.Resolves #9060