Faster manifold check#4839
Draft
Floppy wants to merge 2 commits into
Draft
Conversation
Floppy
added
improvement
in preparation for a rewrite
Floppy
force-pushed
the
faster-manifold-check
branch
from
763ec84 to
0f1af50
Compare
Collaborator
Author
|
6.0.4 is now out, which includes the fix we need, but it's not in Alpine yet: https://pkgs.alpinelinux.org/packages?name=assimp&branch=v3.23 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By using assimp loader and models, we can make the manifold check faster. This PR at present gives at least a 5x speed improvement; loading is super fast, though the manifold check is still slowish as it's done in Ruby. Still a big increase.
Unfortunately due to a bug in assimp's vertex join postprocessing (see assimp/assimp#6278), it currently fails, as all meshes are coming up as non-manifold because of repeated vertices. We'll need to wait for the assimp 6.0.3 release before we can merge this.