Rename zarr.withConsolidation -> zarr.withConsolidatedMetadata#403
Merged
Rename zarr.withConsolidation -> zarr.withConsolidatedMetadata#403
zarr.withConsolidation -> zarr.withConsolidatedMetadata#403Conversation
|
| Name | Type |
|---|---|
| zarrita | Minor |
| @zarrita/ndarray | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
manzt
changed the title
zarr.withConsolidation -> zarr.withConsolidatedMetadata
Adjective form reads better at composition sites and aligns with the zarr-python term users already know (open_consolidated, consolidate_metadata). The longer form makes it immediately clear what is being consolidated — metadata, not chunks — which is the one thing a first-time reader cannot infer from the shorter spelling. All in-tree uses renamed; no deprecation shims because the symbols are unreleased.
manzt
force-pushed
the
push-twttwyxwptzk
branch
from
00574d6 to
5dd2d3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjective form reads better at composition sites and aligns with the zarr-python term users already know (
open_consolidated,consolidate_metadata). The longer form makes it immediately clear what is being consolidated (metadata, not chunks) which is the one thing a first-time reader cannot infer from the shorter spelling.All in-tree uses renamed; no deprecation shims because the symbols are unreleased.