Scroll position sync support #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoschanz
requested changes
Mar 6, 2024
Owner
maoschanz
left a comment
maoschanz
left a comment
There was a problem hiding this comment.
it's pretty hard to read and without comments, so i needed a lot of motivation to review it sorry
| } | ||
| } | ||
| if (highestLowerBoundElement) { | ||
| highestLowerBoundElement.scrollIntoViewIfNeeded(); |
Owner
There was a problem hiding this comment.
why "if needed"? isn't the standard just "scrollIntoView"?
|
|
||
| _ = init_gettext() | ||
|
|
||
| SCRIPT_SCROLL_TO_CURSOR = """ |
Owner
There was a problem hiding this comment.
the script could be in a separate file, and loaded in the init. This way, it could be a js file with syntax coloration
| unsaved_text = doc.get_text(start, end, True) | ||
| cursor_position = doc.get_property("cursor-position") | ||
| text_iter = doc.get_iter_at_offset(cursor_position) | ||
| self._webview_manager.set_cursor_position (text_iter.get_line()+1, text_iter.get_line_offset()+1) |
Owner
There was a problem hiding this comment.
why "+1"? does it not understand zeros? then isn't it problematic that you set cursor_row and column as 0 in the init?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for syncing the scroll position of the webview with the position of the cursor.
I also tried to create a
python3-markdownplugin as described in my comment in issue #35, but I could only find a hack solution. For lists and code blocks, for example, it only outputs the source line of the beginning of the list or code block, respectively.The
sourceposextension frompandocis only available for thecommonmark,commonmark_xandgfmformats. This pull request changes the input format tocommonmarkand for using features like tables etc., the required extensions needs to be enabled or one of the other two formats can be used.Currently, the position is always synced when the document is reloaded, but I think a new option in the preference window can be added for activating or deactivating the synchronization of the scroll position.