Use new mapbender core style utils for placeholder detection and external graphics style#161
Merged
Merged
Conversation
…rnal graphics style
astroidex
approved these changes
Jul 20, 2026
astroidex
left a comment
astroidex
left a comment
Member
There was a problem hiding this comment.
Tested works fine
- png/svg
- placeholder
- size
There was a problem hiding this comment.
Pull request overview
This PR updates the Digitizer’s StyleAdapter to use the new Mapbender core utilities for data-placeholder detection/resolution and external-graphic (icon) styling, avoiding duplicated logic that was moved to the core repository (per mapbender/mapbender#1897).
Changes:
- Replaced local placeholder detection/resolution helpers with
Mapbender.StyleUtil.detectDataPlaceholders,getPlaceholderResolver, andresolvePlaceholders. - Replaced local external-graphic icon style creation/expansion with
Mapbender.Util.ExternalGraphicUtil.getIconStyle. - Minor formatting adjustments in callback function spacing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For mapbender/mapbender#1897, utilities used in the digitizer are now also used by the SearchRouter, they are therefore moved to the core repository. This PR introduces their usage to the digitizer to avoid code duplication.