add fallback character when a character is missing from custom font #13070
+38
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esent in custom font
…ded option in map constructor to enable fallback glyph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes the good first issue #12975
Added an option to show the fallback character when a character from custom font is missing.
Added a new a field in GlyphManager class, enableFallbackGlyph which if set to true, will replace the missing characters with ? of that font stack
If we have enabled this option, then if no character of that font stack is present between unicode id 0 and 255, then we would load 0-255.pbf file of that font stack so that we retrieve the glyph of ? of that fontstack and show that as fallback if any character is missing