Conversation
branyip
previously approved these changes
May 27, 2026
branyip
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the changes!
branyip
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/*.jsfixture modules with plainsrc/*.jsonfiles, loaded at runtime.node:testrunner.eslint-config-mourner, configured for the codebase's 2-space indent, and fixed the resulting issues.lib/generateBuffer.jsintoindex.js, removed thelib/directory, movedreal-world-extents.jsonnext to the scripts that use it, deleted the stalescripts/dumpmason/protoc helper, and removedCHANGELOG.md(easier to maintain it as GitHub release notes).fixtures/and fails if anything changed — so the committed artifacts can't go stale silently.lintand aprepublishOnlyhook that runs lint + build + tests before publish.info.jsonfiles and synced README/API to match.Note on -2 byte fixture changes
After the
pbfdependency upgrade, regenerated tiles are 2 bytes smaller per feature. The previous version emitted an empty packedtagsfield (12 00) for features with no tags; the new version correctly omits the empty field, as expected for proto2 packed repeated fields. Decoded tile content is unchanged — only the redundant empty-field bytes are gone.