Refactor Staging/Production Alternate Host Implementation #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ronilan
force-pushed
the
Refactor-Staging-Production-Host-533-Fix-653
branch
3 times, most recently
from
7381b32 to
4e407be
Compare
ronilan
force-pushed
the
Refactor-Staging-Production-Host-533-Fix-653
branch
from
4e407be to
fe2e4ba
Compare
|
Please rebase now that #900 has been merged and our GitHub Actions are passing again. |
ronilan
force-pushed
the
Refactor-Staging-Production-Host-533-Fix-653
branch
from
fe2e4ba to
b9538e0
Compare
ronilan
force-pushed
the
Refactor-Staging-Production-Host-533-Fix-653
branch
2 times, most recently
from
911336f to
e365c1d
Compare
…pbox#652) was rebased over multiple configuration changes.
…is versa. Removed previous one. Fix CodeQL errors.
- Added a GitHub Actions workflow that runs whenever there is a push to the repo.
- Workflow includes two jobs:
- A matrix job of node versions (10, 12, 14, 16, 18) and operating systems (Linux (ubuntu), Mac and Windows (2019 Enterprise)) that runs all tests against mock and then runs s3 tests against a bucket (located at us-east-1-bucket) specified as a repo secret.
- A matrix job of and NW.js versions (0.64.0, 0.50.2) and node versions (10, 12, ,14, 16) that runs the NW.js test script.
- Moved logic regarding host selection to versioning where all user defined values from package.json are transformed into command options. - Moved testing of feature from `run.test.js` to `versioning.test.js`. - Added `development_host` option. Becomes default option for `publish` `unpublish` when present. - Changed behavior when alternate hosts are defined. Now `production_host` acts as alias to host. Defining `staging_host` or `development_host` is enough to default `publish` and `unpublish` away from production. - When a chain of commands that includes `publish` or `unpublish`, when host not specifically set via command line or environment variable, ALL commands in the chain default away from production. - An invalid `s3_host` option does not result in error and is instead silently ignored. - Change is backwards compatible with previously valid configurations.
ronilan
force-pushed
the
Refactor-Staging-Production-Host-533-Fix-653
branch
from
e365c1d to
7d55567
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request refactors the implementation of production/staging hosts (see: #533). It includes minor feature changes and is backwards compatible with any previously valid configurations.
This pull request comes "on top" of (i.e. includes changes from) #652 (which in turn comes "on top" of #651, which is "on top" of #648, #649, #650). Work is in preparation for resolving issue #654.
Change
Features
development_hostoption. Becomes default option forpublishunpublishwhen present.production_hostacts as alias tohost. Definingstaging_hostordevelopment_hostis enough to defaultpublishandunpublishaway from production.s3_hostoption does not result in error and is instead silently ignored.Bug Fix #653
publishorunpublishand host is not specifically set via command line or environment variable, all commands in the chain default away from production.Code
Tests
run.test.jstoversioning.test.js.