main #4
Open
main #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While indexing, a number of log error can be reported: ``` 2024-06-18T17:11:21,679 ERROR [geonetwork] - Failed to get index field 'resourceTitleObject' value on '10.17600/14000100', caused by Document with id 10.17600/14000100 not found ``` This is due to either remote record links not present in index eg. DOI or to an empty index and document search returns no document at starts. It is triggered mainly in https://github.com/geonetwork/core-geonetwork/blob/main/web/src/main/webapp/xslt/common/index-utils.xsl#L141 but the `recordLink` field is currently not used in main UI. Related to e606996 and 20cc13b
Probably nobody is using this (?) which looks to be an experiment to get XML app and schema localization files from transifex. Also not sure about the source of the `exe` file it relies on.
Minor fixes in version number in tag, publish and md5.
Bumps [org.apache.maven.plugins:maven-dependency-plugin](https://github.com/apache/maven-dependency-plugin) from 3.1.2 to 3.7.0. - [Release notes](https://github.com/apache/maven-dependency-plugin/releases) - [Commits](apache/maven-dependency-plugin@maven-dependency-plugin-3.1.2...maven-dependency-plugin-3.7.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-dependency-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
#7938) * docs: fix images in changelog/version-3.8.0.md * Use Markdowns image syntax instead of the HTML block `figure` to be consistent (and to improve mkdocs mike generation) * docs: improve images in change-log/version-4.0.0-alpha.1.md * Use Markdowns image syntax instead of the HTML block `figure` to be consistent (and to improve mkdocs mike generation) * Apply suggestions from code review Update figures to follow geonetwork docs writing guidelines (makes use of CSS to be similar to display of html figure) --------- Co-authored-by: Jody Garnett <[email protected]>
* Register user / allow to configured allowed email domains * Register user / allow to configured allowed email domains - update migration scripts * Revert accidental change in Messages.properties
* Update SECURITY.md Clarify 3.12 is end of life and no longer supported * Update SECURITY.md --------- Co-authored-by: Jose García <[email protected]>
* Fix user application feedback * Update setting help text and change in the footer the 'Contact' after the 'About' link * Conflict fix (#103) For https://github.com/geonetwork/core-geonetwork/pull/7769/files --------- Co-authored-by: François Prunayre <[email protected]>
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.1.0 to 4.2.1. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v4.1.0...v4.2.1) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add logic to allow multilingual thesaurus titles in the index and translate them when being displayed * Implement multilingual thesaurus titles in iso19139 and iso19115-3.2018
* Add settings fields for localized emails * Add spring bean to initialize feedback email locales from settings field * Modify settings manager to update feedback locales when the settings fields are saved * Create classes for localized emails, their components, and the components' parameters * Implement lang in getIndexField * Localize workflow status emails * Localize metadata publication emails * Localize user feedback emails * Localize RegisterApi emails * Localize PasswordApi emails * Localize WatchListNotifier emails * Localize MailApi emails * Update migration script to only insert settings fields if not present * Add static enum imports for readability * Log a warning when a locale is invalid or missing * Update log modules and messages * Trim language codes defined in settings to handle spaces after commas * Rename translation follows label to translation follows text for consistency * Add back resource bundle 'messages' that was unused before merging main * Add logic to break from loop when email subject and text messages fail
* Associated resource / Consistent labels
Create one directive to display associated resources labels with icon.
The directive is used in all places:
* Record view (list and card layout)
* Editor side panel
* Editor popup
Add the possibility to customize an association label by adding custom translation key in `${lang}-custom.json`
eg.
```json
{
"crossReference-study": "Publication",
"crossReference-campaign": "Campaign",
"crossReference-reuse": "Reuse"
}
```
* Editor / Associated resource popup / Fix element using same DOM id.
* Record view / Improve alignement of source datasets
* Update UtilityDirective.js
* Update related.html
* Associated resource / Consistent labels / Missing template.
* Record view / Associated / Fallback on URL if no title. Do not display twice the list
…8152) * Fix canViewRecord function so that it returned the workflow record. Prior to this fix, it would always return working copy record if it exists. Also updated getInternalId to have better error handling * Update services/src/main/java/org/fao/geonet/api/ApiUtils.java Co-authored-by: Jose García <[email protected]> * Fix number check based on review - was checking wrong value. --------- Co-authored-by: Jose García <[email protected]>
* removed double translation * additional fix for double translation
When using tools to convert OpenAPI to client code eg. ```bash npx openapi-ts -i ./src/gapi/gapi.json -o src/gapi ``` Some reserved word may create invalid generated code. eg. when building typescript: ``` TS1102: 'delete' cannot be called on an identifier in strict mode. [ ```
#8178) * Add info logs to make transaction of working copy merge more traceable * build fix * Update listeners/src/main/java/org/fao/geonet/listener/metadata/draft/DraftUtilities.java Co-authored-by: Jose García <[email protected]> * Update listeners/src/main/java/org/fao/geonet/listener/metadata/draft/DraftUtilities.java Co-authored-by: Jose García <[email protected]> * Update datastorages/cmis/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java Co-authored-by: Jose García <[email protected]> * Update datastorages/cmis/src/main/java/org/fao/geonet/api/records/attachments/CMISStore.java Co-authored-by: Jose García <[email protected]> * add more logs for delete folder * build fix * build fix * Update core/src/main/java/org/fao/geonet/api/records/attachments/FilesystemStore.java Co-authored-by: Jose García <[email protected]> --------- Co-authored-by: Jose García <[email protected]> Co-authored-by: Ian <[email protected]>
Related to JQuery update.
…able (#8229) * Standard / ISO19139 / Formatter / Do not display extent if none available * Update schemas/iso19139/src/main/plugin/iso19139/formatter/xsl-view/view.xsl Co-authored-by: Jose García <[email protected]> --------- Co-authored-by: Jose García <[email protected]>
…d uuid in CSV export (#8238)
Show a warning to the user when an error happens while deleting one or more metadata records.
If an error happens while using the delete, validate or other option of the editor dashboard metadata actions menu then remove the text "Please wait" and the spinner from the button to allow to perform a new action.
Improve documentation and properly target node to delete in case the
forEach loop element is not the one to remove.
eg.
```xml
<section name="Axe - Time"
forEach="/mdb:MD_Metadata/mdb:spatialRepresentationInfo/*/msr:axisDimensionProperties/*[msr:dimensionName/*/@codeListValue = 'time']"
del="ancestor::msr:axisDimensionProperties">
<field xpath="msr:dimensionSize"/>
<field xpath="msr:resolution"/>
</section>
```
Before the change, the remove button was not displayed.
Most of the time the loop element is the one to delete and this case was
fine.
`xmlns:srv` was declared 2 times. Fixes #8221 Related to 27a69df#diff-1f83f3131214c0592eea4a9f65ed3a58a889689a64e9f07bc0753544c0427b29
Fixes "md:scope will be gmd:MD_Scope when it should be gmd:DQ_Scope" See #8220
…etadataUuid}/formatters/{formatterId:.+} (#8269)
This affect PDF exports on working copies.
… store (#8639) * Set the pasteZone for the fileupload directive * Set the pasteZone for the fileupload directive to null
Added translations of analog elements from the iso19139 metadata schema.
Ubuntu 20.04 will become unsupported on 2025-04. Update the images used in the Github Actions runners to one supported. actions/runner-images#11101
* Update workflow status API to check if user can view record (and is an editor) instead or checking owner * Change message to multilingual * remove unused messages * Update check to follow "minimum user profile allowed to view metadata history" logic * Add missing messages * Fix minimum profile not enforced * Fix cannot get status when user cannot edit * Move logic to reusable methods * Fix french messages * Update messages to use translated profile name from json * Fix record not found not handled correctly * Handle record not found for getWorkflowStatusByType
* Set related children's thumbnail to default 4 * Set children thumbnail to 20 for record view page
* Search result record abstract parsing improvement * Update web-ui/src/main/resources/catalog/components/search/resultsview/ResultsviewDirective.js Co-authored-by: Jose García <[email protected]> * format pretty syntax, add double column binding --------- Co-authored-by: Jose García <[email protected]>
…t field name to filter (#8578)
- added xslt helper function to replace placeholders - made sure shared strings can be used for the schematron localisation (schematron-shared.xml) - fix in iso_svrl_for_xslt2.xsl to make sure $loc is also used when wrapped in a function
* Update translations and typo in one entry-code in ISO19139 Portuguese's codelists.xml * Change encoding of ISO19139 Portuguese's codelists.xml from ISO-8859-1 to UTF-8 just like other languages * Add function alias to codelist portuguese as to appear in add online resources
* added statuslabel next to the title in the formatter view (similar to Angular view) * added check on div vs full html render
* feat(geonetwork/web): Add datahub integration. * module and settings params * documentation changes * code review feedback * add plugin to nav tree * remove todo * index static and normalize path (security) * sonar rule * better ignore the satahub path * better path ignoring datahub plugin * more complete documentation for datahub-integration --------- Co-authored-by: Olivia <[email protected]>
* init toml configuration with TOML syntax coloration + init config * datahub activated if plugin present - init * correction of wrong id * Read default config from resources instead of depending on SQL migration * better doc * better Sources admin UI for Datahub * doc improvement * rewrite base path in datahub * Add datahub plugin in build process --------- Co-authored-by: Olivia <[email protected]>
* Coordinated vulnerability disclosure Update security policy for Coordinated vulnerability disclosure. * Update SECURITY.md Co-authored-by: joachimnielandt <[email protected]> * Update SECURITY.md Co-authored-by: joachimnielandt <[email protected]> * Update SECURITY.md Co-authored-by: joachimnielandt <[email protected]> --------- Co-authored-by: Jose García <[email protected]> Co-authored-by: joachimnielandt <[email protected]>
… if translations are configured. (#8718)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.