Skip to content

Set logs level to WARN for production image #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sbrunner wants to merge 1 commit into from
Closed

Set logs level to WARN for production image #3942

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions core/src/main/resources/logback.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
</encoder>
</appender>

<logger name="org.mapfish" level="DEBUG" />
<logger name="com.codahale" level="DEBUG" />
<logger name="org.springframework" level="DEBUG" />
<logger name="org.apache" level="DEBUG" />
<logger name="org.hibernate" level="DEBUG" />
<logger name="org.mapfish" level="WARN" />
<logger name="com.codahale" level="WARN" />
<logger name="org.springframework" level="WARN" />
<logger name="org.apache" level="WARN" />
<logger name="org.hibernate" level="WARN" />
Comment on lines +11 to +15

Copilot AI Jan 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logging configuration affects all environments, not just production. The file core/src/main/resources/logback.xml is packaged into the application and used in all environments (development, testing, and production). Setting these loggers to WARN level will make debugging difficult in development and testing environments where DEBUG-level logs are often needed.

Consider implementing environment-specific logging configuration using one of these approaches:

  1. Use Spring profiles with logback-spring.xml and conditional configuration based on active profiles
  2. Create separate logback configuration files for different environments (e.g., logback-prod.xml, logback-dev.xml)
  3. Use environment variables or system properties to configure log levels dynamically

The current approach will suppress potentially useful DEBUG logs in all environments, which contradicts the PR title suggesting this is "for production image" only.

Copilot uses AI. Check for mistakes.

<root level="INFO">
<appender-ref ref="standardOut" />
Expand Down
Loading