Fix Makefile after project rename#41
Merged
Merged
Conversation
Updated all references from media-encoding.sln to RipSharp.sln. Verified all Makefile targets work correctly: - make help - make restore - make build - make test - make format - make clean - make all (default) Closes #39
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Makefile to reference the correct solution file name after the project was renamed from media-encoding to RipSharp. The Makefile was causing all make commands to fail due to referencing a non-existent solution file.
Changes:
- Updated all
media-encoding.slnreferences toRipSharp.slnin the Makefile - Added a blank line in GlobalUsings.cs for formatting consistency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Updated solution file references from media-encoding.sln to RipSharp.sln across all targets (restore, build, format, test, clean) |
| src/RipSharp.Tests/GlobalUsings.cs | Added blank line after first using statement for formatting consistency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39
Problem
The Makefile was still referencing
media-encoding.sln(the old project name) instead ofRipSharp.sln, causing all make commands to fail.Solution
Updated all solution references in the Makefile from
media-encoding.slntoRipSharp.sln.Verification
Tested all Makefile targets successfully:
make help- Shows available targetsmake restore- Restores NuGet packagesmake build- Builds the solutionmake test- Runs all 112 tests (all pass)make format- Runs dotnet formatmake clean- Cleans build outputsmake all- Default target (build + test)