Skip to content

Conversation

@itheamc
Copy link
Contributor

@itheamc itheamc commented Jun 6, 2024

No description provided.

@josxha josxha assigned kuhnroyal and unassigned kuhnroyal Jun 6, 2024
Copy link
Collaborator

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @itheamc, thank you for keeping your pull request updated with the main branch.

The user has the option to add annotations like circles, symbols and so on. After the user changes the style of the map the annotations added by the user should be still on the map to avoid an inconcistent state between flutter and the maplibre SDKs.

@josxha
Copy link
Collaborator

josxha commented Jun 23, 2024

Hi @itheamc, I've seen that you clicked on "Resolve conversations" for my comments but 4 haven't been implemented. Could you give some quick details what's the reason please?

@josxha josxha added this to the v0.20.1 milestone Oct 3, 2024
@josxha josxha removed this from the v0.21.0 milestone Feb 24, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a setStyle method to the MapLibre GL controller that allows dynamically changing the map's style at runtime. The implementation spans across all platform layers (interface, web, iOS, Android) and provides support for various style formats including URLs, local assets, file paths, and raw JSON.

  • Adds setStyle method to the platform interface with comprehensive documentation
  • Implements the method across all platform-specific controllers (web, iOS, Android)
  • Updates the example app to demonstrate programmatic style setting with a delay

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
maplibre_gl_platform_interface/lib/src/maplibre_gl_platform_interface.dart Defines the abstract setStyle method with detailed documentation
maplibre_gl/lib/src/controller.dart Implements the main controller's setStyle method
maplibre_gl_platform_interface/lib/src/method_channel_maplibre_gl.dart Implements method channel communication for setStyle
maplibre_gl_web/lib/src/maplibre_web_gl_platform.dart Implements web platform-specific setStyle method
maplibre_gl/ios/maplibre_gl/Sources/maplibre_gl/MapLibreMapController.swift Adds iOS native implementation with error handling
maplibre_gl/android/src/main/java/org/maplibre/maplibregl/MapLibreMapController.java Adds Android native implementation with null checking
maplibre_gl_example/lib/local_style.dart Updates example to use programmatic style setting instead of constructor parameter

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gabbopalma gabbopalma changed the base branch from main to release-0.23.0 September 30, 2025 08:14
@gabbopalma
Copy link
Collaborator

Hello @itheamc, and thank you for your contribution. I apologize for the delay in reviewing it.
It will be released soon in version 0.23.0.

I took the liberty of applying some changes to your PR, but the basis was really good!

@gabbopalma gabbopalma merged commit 1ef1779 into maplibre:release-0.23.0 Sep 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants