Skip to content

Conversation

@smallTrogdor
Copy link
Contributor

No description provided.

Copy link
Collaborator

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smallTrogdor!
Let's not forget the example app under /example/pubspec.yaml. Please either bump the version or use a path dependency.

maplibre_gl: ^0.20.0

@josxha josxha added this to the v0.21.0 milestone Feb 24, 2025
@smallTrogdor
Copy link
Contributor Author

smallTrogdor commented Feb 25, 2025

Needed to upgrade the device_info_plus to latest version as well to get it it to work with Flutter 3.29.0 (win32 causing issues).

Also, the melos bootstrap in the CI is not generating the pubspec_overrides.yaml necessary to override the package dependencies 😞 will look into this tomorrow or some help needed

=== EDIT

maybe running the CI with debug enabled will give more insights. local build works after update of device_info_plus...

@josxha
Copy link
Collaborator

josxha commented Feb 25, 2025

Not sure why this happens. 😕 A workflow debug log is here: https://github.com/maplibre/flutter-maplibre-gl/actions/runs/13532949769/job/37819080286

It's not worth to spend too much time with it. Let's use v0.20.0 as version in the example app since that seems to work.

@kuhnroyal
Copy link
Contributor

The problem arises due to the example project being named "example". You can see from the melos logs that it runs flutter pub get in the example before bootstraping. The root melos workspace is also Dart/Flutter project which can have an example.
I renamed it to fix this.
You can pull this separately in a fresh PR if you prefer.

You can remove the include-private: true blocks, this is only relevant for releases via melos.

@smallTrogdor
Copy link
Contributor Author

Dear @kuhnroyal,

thanks for bringing some clarity to this one. Thanks @josxha for the workflow debug run, helped 👍

So I removed the include-private: true from the ci again...

@smallTrogdor smallTrogdor requested a review from josxha February 26, 2025 11:33
@josxha
Copy link
Collaborator

josxha commented Feb 26, 2025

The problem arises due to the example project being named "example". You can see from the melos logs that it runs flutter pub get in the example before bootstraping. The root melos workspace is also Dart/Flutter project which can have an example.
I renamed it to fix this.

Ohh I see! Thanks @kuhnroyal for resolving the problem. 😄

Copy link
Collaborator

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smallTrogdor for the contribution!

@josxha josxha merged commit e7adbf9 into maplibre:main Feb 26, 2025
9 checks passed
@smallTrogdor smallTrogdor deleted the prepare-0-21-0-release branch February 27, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants