-
Notifications
You must be signed in to change notification settings - Fork 171
feat: update maplibre-native to the latest versions #552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…iOS 6.12.1), update Gradle and it's dependencies
|
@josxha could you please approve workflow to test builds? I don't have Apple device to check if I updated iOS deps correctly. |
|
Nice, iOS and Android builds! This is ready for the review then, @josxha. I can commit CHANGELOG.md update if needed. |
|
Can someone review? |
|
@m0nac0 |
|
Just for the context: Immich uses Flutter for their mobile app and Of course there are for sure other projects that will like to have PMTiles support in Flutter as well. |
|
I don't like pinging, but anyone? |
|
@m0nac0 @kuhnroyal @josxha |
|
I understand everyone is busy, but I really don't want to fork this. Flutter library for now uses almost a year old MapLibre iOS library and half year Android. I wouldn't push if they just contain some bug fixes and dependencies updates, but PMTiles support is really cool. |
|
@savely-krasovsky Code reviews are a longer standing problem of the project. There are a couple other open pull requests looking for a review too. |
|
@kuhnroyal could you review please? I rebased it. |
|
Yea, working on it. Looking into enabling PMTiles for web as well. |
|
Thank you! Will wait. |
Newer versions of maplibre-native contain a lot of improvements and bug fixes, including long-awaited PMTiles support. I prepared a patch which updates: - Android to 11.8.1 - iOS to 6.12.1 - Gradle to 8.13 (it's already Gradle 9 coming soon, we need to migrate ASAP) Also it adds PMTiles example into example app. I tested it with Immich app and tried PMTiles source. It works! --------- Co-authored-by: Peter Leibiger <[email protected]>
Newer versions of maplibre-native contain a lot of improvements and bug fixes, including long-awaited PMTiles support. I prepared a patch which updates:
Also it adds PMTiles example into example app.
I tested it with Immich app and tried PMTiles source. It works!