feat: map snapshot #610
feat: map snapshot #610
Conversation
gabbopalma
left a comment
gabbopalma
left a comment
There was a problem hiding this comment.
Hi! Thank you for your contributions and efforts 😄
We should do some checks on the changes, but nothing major
Could you also run dart format . from from the package root when you're done with all the changes?
| 'cameraPosition': { | ||
| 'target': { | ||
| 'latitude': cameraPosition.target.latitude, | ||
| 'longitude': cameraPosition.target.longitude, | ||
| }, | ||
| 'zoom': cameraPosition.zoom, | ||
| 'bearing': cameraPosition.bearing, | ||
| 'tilt': cameraPosition.tilt, | ||
| }, |
There was a problem hiding this comment.
Use cameraPosition.toMap() method, instead of manual formatting
| /// Represents a marker to be added to the map snapshot. | ||
| class MapMarker { | ||
| final LatLng position; | ||
| final Uint8List iconData; | ||
| final double iconSize; | ||
| final String? label; | ||
|
|
||
| const MapMarker({ | ||
| required this.position, | ||
| required this.iconData, | ||
| this.iconSize = 32.0, | ||
| this.label, | ||
| }); | ||
|
|
||
| Map<String, dynamic> toMap() { | ||
| return { | ||
| 'position': { | ||
| 'latitude': position.latitude, | ||
| 'longitude': position.longitude, | ||
| }, | ||
| 'iconData': iconData, | ||
| 'iconSize': iconSize, | ||
| 'label': label, | ||
| }; | ||
| } | ||
| } |
There was a problem hiding this comment.
Put this code inside a file into maplibre_gl/lib/src path and remove it from global.dart.
Rename this class with a name that better reflects the specific behavior of the map snapshot
Use the LatLng.toJson() method instead of manual mapping the position data
| if (width == null || height == null || styleUrl == null || cameraPositionMap == null) { | ||
| result.error("INVALID_ARGUMENTS", "Missing required arguments", null); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Also check if styleUrl is empty and, if so, return an error
| if (width == null || height == null || styleUrl == null || cameraPositionMap == null) { | |
| result.error("INVALID_ARGUMENTS", "Missing required arguments", null); | |
| return; | |
| } | |
| if (width == null || height == null || styleUrl == null || cameraPositionMap == null) { | |
| result.error("INVALID_ARGUMENTS", "Missing required arguments", null); | |
| return; | |
| } | |
| if (styleUrl.isEmpty()) { | |
| result.error("INVALID_ARGUMENTS", "Style URL cannot be empty", null); | |
| return; | |
| } |
|
|
||
| setState(() { | ||
| _snapshotImage = imageData; | ||
| _currentCity = randomCity['name'] as String; |
There was a problem hiding this comment.
Adjust the casting type of the variable
| _currentCity = randomCity['name'] as String; | |
| _currentCity = randomCity['name'] as String?; |
| final cameraPosition = CameraPosition( | ||
| target: LatLng(randomCity['lat'] as double, randomCity['lng'] as double), | ||
| zoom: _currentZoom, | ||
| ); |
There was a problem hiding this comment.
Adjust the casting type of the variables
| final cameraPosition = CameraPosition( | |
| target: LatLng(randomCity['lat'] as double, randomCity['lng'] as double), | |
| zoom: _currentZoom, | |
| ); | |
| final cameraPosition = CameraPosition( | |
| target: LatLng(randomCity['lat']! as double, randomCity['lng']! as double), | |
| zoom: _currentZoom, | |
| ); |
| // Create markers if enabled | ||
| List<MapMarker>? markers; | ||
| if (_showMarkers) { | ||
| final cityName = randomCity['name'] as String; |
There was a problem hiding this comment.
Adjust the casting type of the variable
| final cityName = randomCity['name'] as String; | |
| final cityName = randomCity['name']! as String; |
|
|
||
| markers = [ | ||
| MapMarker( | ||
| position: LatLng(randomCity['lat'] as double, randomCity['lng'] as double), |
There was a problem hiding this comment.
Adjust the casting type of the variables
| position: LatLng(randomCity['lat'] as double, randomCity['lng'] as double), | |
| position: LatLng(randomCity['lat']! as double, randomCity['lng']! as double), |
| location: ^5.0.3 | ||
| maplibre_gl: ^0.22.0 | ||
| maplibre_gl: | ||
| path: ../maplibre_gl |
There was a problem hiding this comment.
Remove this local dependency. You can use the melos bootstrap command to synchronize all dependencies across packages.
If melos is not activated, activate it first with dart pub global activate melos from the root folder of the maplibre package
| /// Creates a snapshot of a map with the specified parameters. | ||
| /// | ||
| /// [width] and [height] define the dimensions of the snapshot in pixels. | ||
| /// [styleUrl] is the URL of the map style to use. | ||
| /// [cameraPosition] defines the camera position (center and zoom level) for the snapshot. | ||
| /// [markers] is an optional list of markers to add to the snapshot. | ||
| /// | ||
| /// Returns a [Uint8List] containing the PNG image data of the snapshot. |
There was a problem hiding this comment.
Specific that this method is only available for iOS and Android, and not for Web.
gabbopalma
added
enhancement
| /// [markers] is an optional list of markers to add to the snapshot. | ||
| /// | ||
| /// Returns a [Uint8List] containing the PNG image data of the snapshot. | ||
| Future<Uint8List> startMapSnapshot({ |
There was a problem hiding this comment.
nitpick: The function should not be named startMapSnapshot as it not only starts the process, but also waits for it to finish and returns the result.
How about takeMapSnapshot or getMapSnapshot?
3 participants
feat: Add map snapshot functionality