Skip to content

Conversation

@gabbopalma
Copy link
Collaborator

Reverts #603. This will be merged in release-0.23.0 branch

Copilot AI review requested due to automatic review settings September 17, 2025 14:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that added support for setting style JSON on iOS and web platforms. The revert is intended for the release-0.23.0 branch to remove this functionality.

Key changes:

  • Removes JSON style support from iOS and web platforms
  • Reverts web implementation to use style strings instead of style objects
  • Updates documentation to clarify JSON styles are only supported on Android

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
maplibre_gl_web/lib/src/ui/map.dart Reverts setStyle method to not use jsify on style parameter
maplibre_gl_web/lib/src/options_sink.dart Changes setStyle method back to setStyleString
maplibre_gl_web/lib/src/maplibre_web_gl_platform.dart Reverts to using styleString and setStyleString method
maplibre_gl_web/lib/src/convert.dart Removes JSON parsing logic for style strings
maplibre_gl_web/lib/maplibre_gl_web.dart Removes dart:convert import
maplibre_gl/lib/src/maplibre_map.dart Updates documentation to specify JSON support is Android-only
maplibre_gl/ios/maplibre_gl/Sources/maplibre_gl/MapLibreMapController.swift Removes JSON style support and reverts to URL-based styling
maplibre_gl/ios/.gitignore Removes .build entry
maplibre_gl/README.md Updates documentation to clarify JSON support limitation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gabbopalma gabbopalma enabled auto-merge (squash) September 17, 2025 14:56
@gabbopalma gabbopalma merged commit e2964c2 into main Sep 17, 2025
17 checks passed
@gabbopalma gabbopalma deleted the revert-603-style-json branch September 17, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants