-
Notifications
You must be signed in to change notification settings - Fork 171
Introduces feature #642 #643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces feature #642 #643
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the onCameraMove callback feature (#642) to provide real-time notifications when the camera position changes on the map. The implementation adds the callback at multiple levels of the widget hierarchy.
- Adds
OnCameraMoveCallbacktypedef for camera movement events - Wires the callback through the MapLibreMap widget and controller
- Integrates the callback invocation in the platform's camera move stream
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| maplibre_gl/lib/src/maplibre_map.dart | Adds onCameraMove parameter to widget constructor and passes it to controller |
| maplibre_gl/lib/src/controller.dart | Defines OnCameraMoveCallback typedef and implements callback invocation in camera move stream |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
|
Hi @andynewman10, for correct and complete implementation, add the CameraPosition argument, which is already available, to the new onCameraMove. It may not be on the iOS, so please check |
Wires
onCameraMovein the controller and inMapLibreMapclass.Tested on web successfully.