Skip to content

Conversation

@andrea689
Copy link
Contributor

@andrea689 andrea689 commented Oct 7, 2025

closes #652

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where annotation tap callbacks were being called twice due to duplicate code handling the same functionality. The fix removes the redundant code block that was invoking annotation callbacks before the proper null-check and callback handling.

  • Removed duplicate annotation callback handling code
  • Updated changelog to document the fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
maplibre_gl/lib/src/controller.dart Removed duplicate code block that was causing annotation tap callbacks to be called twice
maplibre_gl/CHANGELOG.md Added changelog entry documenting the fix for issue #652

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@gabbopalma gabbopalma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it seems there was an unhandled merge conflict.
LGTM. Thank you for your contribution and bug fix.
It will be included in the next minor release as soon as possible.

@gabbopalma gabbopalma added this to the 0.24.1 milestone Oct 7, 2025
@gabbopalma gabbopalma changed the base branch from main to release-0.24.1 October 16, 2025 07:50
@gabbopalma gabbopalma merged commit dfd98a0 into maplibre:release-0.24.1 Oct 16, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] annotationTappedCallbacks called twice

2 participants