[Draft] Global state expression #5613
Draft
+3,732
−1,820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbigniewmatysek-tomtom
changed the title
…obal-state-expression
HarelM
reviewed
Apr 28, 2025
| "@maplibre/maplibre-gl-style-spec": "^23.1.0", | ||
| "@types/geojson": "^7946.0.16", | ||
| "@maplibre/maplibre-gl-style-spec": "^23.2.1", | ||
| "@types/geojson": "^7946.0.14", |
There was a problem hiding this comment.
This looks like a bad merge...?
HarelM
reviewed
Apr 28, 2025
|
|
||
| if (this._loaded) { | ||
| for (const sourceCache of Object.values(this.style.sourceCaches)) { | ||
| sourceCache.reload(); |
There was a problem hiding this comment.
Is there a less expensive way to do it? I haven't seen featureState use the same flow, so is there a different way this can/should be solved?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
global-stateexpression implementation.See the style spec update and related issues:
maplibre/maplibre-style-spec#886
#4964
Launch Checklist
CHANGELOG.mdunder the## mainsection.