-
-
Notifications
You must be signed in to change notification settings - Fork 932
Make LngLatBounds#intersects return true when bounds touch along an edge or at a corner
#6802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+18
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
lucaswoj
commented
Dec 2, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6802 +/- ##
==========================================
- Coverage 92.42% 92.40% -0.02%
==========================================
Files 288 288
Lines 23809 23807 -2
Branches 5057 5056 -1
==========================================
- Hits 22006 22000 -6
- Misses 1803 1807 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
LngLatBounds#intersects return true when bounds touch along an edge or at a corner
…t-bounds # Conflicts: # CHANGELOG.md
HarelM
reviewed
Dec 2, 2025
Collaborator
|
Thanks for looking into this. I've added a comment about one of the calculations. |
HarelM
reviewed
Dec 2, 2025
HarelM
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6800 (comment)
LngLatBounds#intersectswasn't treating coincident edges as an intersection. I've updated the behavior so that bounds which touch along an edge or corner are now considered intersecting. This is more intuitive and consistent with how most spatial libraries handle intersection checks.Launch Checklist
Include before/after visuals or gifs if this PR includes visual changes.Post benchmark scores.CHANGELOG.mdunder the## mainsection.