Slight mods to PR 6800 #6809
Open
Slight mods to PR 6800 #6809
+63
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
HarelM
reviewed
Dec 4, 2025
HarelM
reviewed
Dec 4, 2025
wayofthefuture
commented
Dec 4, 2025
Collaborator
|
There were changes to applydiff but no changes to tests, can you add a test forv the changes there? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 6795-use-only-bounds #6809 +/- ##
=====================================================
Coverage 92.41% 92.41%
=====================================================
Files 288 288
Lines 23803 23812 +9
Branches 5056 5056
=====================================================
+ Hits 21998 22007 +9
Misses 1805 1805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Better... i was able to revert the behavior change i think |
wayofthefuture
commented
Dec 4, 2025
HarelM
reviewed
Dec 4, 2025
HarelM
reviewed
Dec 4, 2025
wayofthefuture
force-pushed
the
6800-mods
branch
from
aad4fab to
2dd22de
Compare
wayofthefuture
force-pushed
the
6800-mods
branch
from
2dd22de to
a42a7a4
Compare
Collaborator
Author
|
I flattened updateable because it was just staring at me... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight mods to PR 6800