Skip to content

Conversation

@lucaswoj
Copy link
Contributor

@lucaswoj lucaswoj commented Dec 4, 2025

Inspired by #6803 (comment)
Related to #4364

This PR improves the GeoJSONSourceSetData and GeoJSONSourceUpdateData benchmarks by making them use 100k features instead of 10k features. Working with only 10k features has never really been a performance problem for GL JS and 10k points hit rather different performance bottlenecks than 100k points.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.42%. Comparing base (50d412d) to head (fb08cd7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6810   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         288      288           
  Lines       23807    23807           
  Branches     5056     5056           
=======================================
  Hits        22003    22003           
  Misses       1804     1804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Dec 4, 2025

This is ready for review

Copy link
Collaborator

@HarelM HarelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about the removal of the await?

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Dec 4, 2025

Are you sure about the removal of the await?

Yup. That method doesn't return a promise.

@HarelM
Copy link
Collaborator

HarelM commented Dec 4, 2025

It can if you want it to. It means that updates are aggregated to some extent.

@lucaswoj
Copy link
Contributor Author

lucaswoj commented Dec 4, 2025

The waitForCompletion option doesn't work for this benchmark because it resolves after the source finishes updating but before the tiles finish. We care about the tiles.

@HarelM HarelM merged commit f681bbb into maplibre:main Dec 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants