-
-
Notifications
You must be signed in to change notification settings - Fork 932
Improve GeoJSONSourceSetData and GeoJSONSourceUpdateData benchmarks
#6810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6810 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 288 288
Lines 23807 23807
Branches 5056 5056
=======================================
Hits 22003 22003
Misses 1804 1804 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This is ready for review |
HarelM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about the removal of the await?
Yup. That method doesn't return a promise. |
|
It can if you want it to. It means that updates are aggregated to some extent. |
|
The |
Inspired by #6803 (comment)
Related to #4364
This PR improves the
GeoJSONSourceSetDataandGeoJSONSourceUpdateDatabenchmarks by making them use 100k features instead of 10k features. Working with only 10k features has never really been a performance problem for GL JS and 10k points hit rather different performance bottlenecks than 100k points.Launch Checklist
CHANGELOG.mdunder the## mainsection.