chore!: bump tsconfig target to ES2022#7404
Open
CommanderStorm wants to merge 1 commit intomaplibre:mainfrom
Open
chore!: bump tsconfig target to ES2022#7404CommanderStorm wants to merge 1 commit intomaplibre:mainfrom
ES2022#7404CommanderStorm wants to merge 1 commit intomaplibre:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ES2022was the version of JS that browsers reliably supported in 2022.We are currently on 2016, but are using 2020 features (-> if users bundle us, this is relevant), so realistically, this is not actually a bump, but maybe this might.
This change aligns us with the wider ecosystem, but if someone has not updated their browser in 5 years, but wants to update this would be problematic -> a breakign change.
This PR will fail the bundle size check, but since we are not going to merge it now, that is intentional. this part will need to change once we are ready to pivot towards v6