docs: split html and js and indicate the new items#7440
docs: split html and js and indicate the new items#7440CommanderStorm wants to merge 5 commits intomaplibre:mainfrom
Conversation
| const maplibreUnpkg = `https://unpkg.com/maplibre-gl@${packageJson.version}/`; | ||
| const newExamples = getNewExamples(); | ||
| if (newExamples.size > 0) { | ||
| console.log(`${newExamples.size} of ${files.length} examples marked as "new": ${newExamples.map(f => path.basename(f).join(', ')}`); |
|
How does the markdown of this looks like? === Tab1 content === Tab2 content 2 So if I'm not mistaken, this is zensical (mkdocs) specific which I would like to avoid to be able to port the docs if needed in the future. Same for the header. While I think this is a nice addition to the docs, I think it's not worth the complexity and "vendor lock". sorry... :-/ |
if we have another solution we want to migrate to they likey support tabs. Realistically, there will always be coupling to the docs framework. Just have a look at our social cards or how we do admonations.. When looking at the examples, they look much more approchable this way if we "hide" the ugly html and show only the js. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
==========================================
+ Coverage 92.73% 92.76% +0.02%
==========================================
Files 289 289
Lines 24007 24021 +14
Branches 5096 5100 +4
==========================================
+ Hits 22264 22283 +19
+ Misses 1743 1738 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I completely disagree, as I was the person who moved the docs from mapbox's proprietary framework and deleted the docusaurus approach I can tell you that I've worked hard to keep it simple, maintainable, and readable. |
|
If the above message sounds too aggressive I'm sorry, I'll be happy to discuss this online if you'd like. |
|
Let's try to find a time to talk about it online please. |
basically, this