Conversation
| expect(s1.length).toBeLessThan(5); | ||
| const s2 = setMinus(expectedEntriesInSourcemapJSON, actualEntriesInSourcemapJSON); | ||
| expect(s2.length).toBeLessThan(17); | ||
| expect(s2.length).toBeLessThan(18); |
There was a problem hiding this comment.
@birkskyum since you touched this last, what does this mean? For me this test is a bit magical and I don't fully get what is beign tested, but likely this just me not having worked with sourcemaps 😓
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7453 +/- ##
==========================================
- Coverage 92.77% 92.77% -0.01%
==========================================
Files 289 289
Lines 24017 24039 +22
Branches 5100 5084 -16
==========================================
+ Hits 22282 22302 +20
- Misses 1735 1737 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I've added a link in the following issue, just in case: |
| 'CooperativeGesturesHandler.WindowsHelpText': 'Use Ctrl + scroll to zoom the map', | ||
| 'CooperativeGesturesHandler.MacHelpText': 'Use ⌘ + scroll to zoom the map', | ||
| 'CooperativeGesturesHandler.MobileHelpText': 'Use two fingers to move the map', | ||
| 'Map.WebGL2NotSupported.Full': 'We are sorry, but it seems that your browser does not support WebGL, a technology for rendering 3D graphics on the web.', |
There was a problem hiding this comment.
It should say WebGL2 instead of just webgl
| 'Map.WebGL2NotSupported.Full': 'We are sorry, but it seems that your browser does not support WebGL2, a technology for rendering 3D graphics on the web.', | ||
| 'Map.WebGL2NotSupported.Short': 'WebGL2 is required to display this map.', | ||
| 'Map.WebGL2NotSupported.LearnMore': 'Read more', | ||
| 'Map.WebGL2NotSupported.LearnMoreUrl': 'https://wiki.openstreetmap.org/wiki/This_map_requires_WebGL', |
There was a problem hiding this comment.
This page only speak of "WebGL" being required - not a single reference to webgl2. I don't know if we best make a separate page for webgl2, or if a note on the existing page about maplibre v6+.
There was a problem hiding this comment.
Once we upgrade OSM I will have to upgrade that wiki anyhow. So should be the require a different docs.
Alternatively, we can just have a dup of that, but it would likely end up being a dup..
3 participants
This PR is the part of v6 that will drop the webgl1 support.
We have talked about this for a while and I don't think we have gotten a lot of pushback.
This blocks a few of the more agressive performance fixes for 3d terrain, such as not needing 2 frames every frame (-> async)