fix: add accept headers for MLT and MVT#7483
Open
CommanderStorm wants to merge 2 commits intomaplibre:mainfrom
Open
fix: add accept headers for MLT and MVT#7483CommanderStorm wants to merge 2 commits intomaplibre:mainfrom
CommanderStorm wants to merge 2 commits intomaplibre:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7483 +/- ##
==========================================
+ Coverage 92.80% 92.81% +0.01%
==========================================
Files 290 290
Lines 24087 24095 +8
Branches 5099 5103 +4
==========================================
+ Hits 22354 22364 +10
+ Misses 1733 1731 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
just to be save, lets put this under v6. |
Collaborator
|
Looks good, thanks, let's wait for version 6 with this. |
Collaborator
|
See discussion here: And PR here: Let's finish the discussion there first before merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in maplibre/maplibre-style-spec#1251 (comment) we should include the Accept header.
This is important for us as a tile server, given that we otherwise have no clue if we should transcode an MLT <-> MVT source.