Skip to content

fix: add accept headers for MLT and MVT#7483

Open
CommanderStorm wants to merge 2 commits intomaplibre:mainfrom
CommanderStorm:include-accept-headers
Open

fix: add accept headers for MLT and MVT#7483
CommanderStorm wants to merge 2 commits intomaplibre:mainfrom
CommanderStorm:include-accept-headers

Conversation

@CommanderStorm
Copy link
Copy Markdown
Member

As requested in maplibre/maplibre-style-spec#1251 (comment) we should include the Accept header.

This is important for us as a tile server, given that we otherwise have no clue if we should transcode an MLT <-> MVT source.

@CommanderStorm CommanderStorm requested review from HarelM and nyurik April 17, 2026 04:04
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.81%. Comparing base (7499aa3) to head (dcb83a7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7483      +/-   ##
==========================================
+ Coverage   92.80%   92.81%   +0.01%     
==========================================
  Files         290      290              
  Lines       24087    24095       +8     
  Branches     5099     5103       +4     
==========================================
+ Hits        22354    22364      +10     
+ Misses       1733     1731       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nyurik
nyurik previously approved these changes Apr 17, 2026
Copy link
Copy Markdown
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CommanderStorm CommanderStorm modified the milestone: 6.0 Apr 17, 2026
@CommanderStorm
Copy link
Copy Markdown
Member Author

just to be save, lets put this under v6.
I don't think this is breaking, but we never know what people are doing with headers... maybe WAF filtering for incoming requests or something bad.. Not sure

@HarelM
Copy link
Copy Markdown
Collaborator

HarelM commented Apr 18, 2026

Looks good, thanks, let's wait for version 6 with this.

@HarelM
Copy link
Copy Markdown
Collaborator

HarelM commented Apr 20, 2026

See discussion here:

And PR here:

Let's finish the discussion there first before merging this.

@HarelM HarelM dismissed nyurik’s stale review April 20, 2026 06:08

Needs discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants