-
-
Notifications
You must be signed in to change notification settings - Fork 439
DRAFT: Just to show deltas between repos #3904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
DRAFT: Just to show deltas between repos #3904
Conversation
…ation indicator Also release a new version for ios
prepare android release
pull latest changes from maplibre
location indicator layer ios 2
make ios release
follow location indicator during navigation with a flag
fix crash when reloading
rebase main
Make some of the map transform functions virtual to allow for overriding by a child implementation and expose some of the previously private functionality as protected.
This class inherits from the map Transform class and overrides the virtual functions to allow for concurrent animations for different types of animations at the same time rather than overriding the previous animation with the latest one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR demonstrates differences between two repository states, showing updates to submodule references, refactoring of test infrastructure, implementation of scissor rect functionality, plugin system enhancements, and various rendering improvements.
- Updated several vendor submodule commit references
- Refactored transform tests to use parameterized testing
- Implemented scissor rect support across rendering backends
- Added plugin system for custom file sources and style filters
- Enhanced symbol rendering with offset handling
Reviewed Changes
Copilot reviewed 183 out of 195 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vendor/* | Updated submodule commit references for rapidjson, kdbush, filesystem, expected-lite, args, and supercluster |
| test/map/transform.test.cpp | Refactored tests to use parameterized testing and added TransformActive tests |
| test/util/offscreen_texture.test.cpp | Simplified scissor test setup by consolidating glScissor calls |
| src/mbgl/vulkan/* | Added scissor rect support for Vulkan rendering backend |
| src/mbgl/gl/* | Updated OpenGL scissor test to use ScissorRect structure |
| src/mbgl/mtl/* | Added scissor rect support for Metal rendering backend |
| src/mbgl/renderer/* | Integrated scissor rect into paint parameters |
| src/mbgl/style/* | Added style filter plugin system and transition easing support |
| src/mbgl/plugin/* | Implemented plugin infrastructure for file sources, style filters, and feature collections |
| src/mbgl/map/transform* | Added TransformActive for concurrent animations and frustum offset support |
| platform/ios/* | Added location indicator layer, plugin protocol handlers, and style filters |
| platform/darwin/* | Added location array support and updated transition API |
| shaders/* | Updated symbol shaders to conditionally apply perspective based on offset |
Comments suppressed due to low confidence (8)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Get latest maplibre changes
Fix ios CI release
fix webgpu symbol rendering shader
In order to do things like path eating precisely, the exact position of the puck needs to be known.
Add a listener that watches the puck position
fix android ci storage
DONE