Skip to content

Conversation

@yousifd
Copy link
Collaborator

@yousifd yousifd commented Nov 5, 2025

Modify the symbol shaders to check for is_offset before applying the perspective scaling for all rendering backends. Added is_offset to the symbol shader UBO from the drawable.

Previous PR: #3341

MapLibre GL JS PR with more information: maplibre/maplibre-gl-js#5625

@github-actions github-actions bot added cpp-core OpenGL Issues related to the OpenGL renderer backend Vulkan WebGPU labels Nov 5, 2025
@github-actions
Copy link

github-actions bot commented Nov 6, 2025

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3928-compared-to-main.txt

@github-actions
Copy link

github-actions bot commented Nov 9, 2025

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +1.6% +2.61Mi  +0.8%  +253Ki    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3928-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +47% +54.5Mi  +450% +26.9Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3928-compared-to-legacy.txt

@louwers
Copy link
Member

louwers commented Nov 30, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp-core OpenGL Issues related to the OpenGL renderer backend Vulkan WebGPU

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants